Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Thorvg] Update Thorvg port to v0.12.1 #36179

Merged
merged 6 commits into from
Jan 17, 2024

Conversation

rinechran
Copy link
Contributor

@rinechran rinechran commented Jan 15, 2024

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@rinechran
Copy link
Contributor Author

currently have not uwp support, but I built from cd/ci to uwp I wonder what I did wrong.

@dg0yt
Copy link
Contributor

dg0yt commented Jan 15, 2024

FAILED: src/thorvg-0.dll.p/loaders_ttf_tvgTtfLoader.cpp.obj 
"C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.38.33130/bin/Hostx64/x64/cl.exe" "-Isrc\thorvg-0.dll.p" "-Isrc" "-I..\src\v0.12.1-747f5d510c.clean\src" "-Iinc" "-I..\src\v0.12.1-747f5d510c.clean\inc" "-I." "-I..\src\v0.12.1-747f5d510c.clean" "-Isrc\bindings\capi" "-I..\src\v0.12.1-747f5d510c.clean\src\bindings\capi" "-Isrc\renderer" "-I..\src\v0.12.1-747f5d510c.clean\src\renderer" "-Isrc\renderer\sw_engine" "-I..\src\v0.12.1-747f5d510c.clean\src\renderer\sw_engine" "-Isrc\common" "-I..\src\v0.12.1-747f5d510c.clean\src\common" "-Isrc\loaders" "-I..\src\v0.12.1-747f5d510c.clean\src\loaders" "-Isrc\loaders\tvg" "-I..\src\v0.12.1-747f5d510c.clean\src\loaders\tvg" "-Isrc\loaders\svg" "-I..\src\v0.12.1-747f5d510c.clean\src\loaders\svg" "-Isrc\loaders\ttf" "-I..\src\v0.12.1-747f5d510c.clean\src\loaders\ttf" "-Isrc\loaders\lottie" "-I..\src\v0.12.1-747f5d510c.clean\src\loaders\lottie" "-Isrc\loaders\png" "-I..\src\v0.12.1-747f5d510c.clean\src\loaders\png" "-Isrc\loaders\jpg" "-I..\src\v0.12.1-747f5d510c.clean\src\loaders\jpg" "-Isrc\loaders\raw" "-I..\src\v0.12.1-747f5d510c.clean\src\loaders\raw" "-Isrc\savers" "-I..\src\v0.12.1-747f5d510c.clean\src\savers" "-Isrc\savers\tvg" "-I..\src\v0.12.1-747f5d510c.clean\src\savers\tvg" "-ID:/installed/x64-uwp/include" "/MDd" "/nologo" "/showIncludes" "/utf-8" "/W2" "/EHsc" "/std:c++14" "/permissive-" "/O1" "/Gw" "/Zi" "-DEXAMPLE_DIR=\"D:/b/thorvg/src/v0.12.1-747f5d510c.clean/src/examples/resources\"" "-DTEST_DIR=\"D:/b/thorvg/src/v0.12.1-747f5d510c.clean/test/resources\"" "-DWIN32" "-D_WINDOWS" "-D_UNICODE" "-DUNICODE" "-DWINAPI_FAMILY=WINAPI_FAMILY_APP" "-D__WRL_NO_DEFAULT_LIB__" "-nologo" "-Z7" "-MP" "-GS" "-Gd" "-Gm-" "-W3" "-WX-" "-Zc:wchar_t" "-Zc:inline" "-Zc:forScope" "-fp:precise" "-Oy-" "-EHsc" "-utf-8" "-ZW:nostdlib" "-D_DEBUG" "-MDd" "-Od" "-RTC1" "-DTVG_EXPORT" "-DTVG_BUILD" "/Fdsrc\thorvg-0.dll.p\loaders_ttf_tvgTtfLoader.cpp.pdb" /Fosrc/thorvg-0.dll.p/loaders_ttf_tvgTtfLoader.cpp.obj "/c" ../src/v0.12.1-747f5d510c.clean/src/loaders/ttf/tvgTtfLoader.cpp
cl : Command line warning D9025 : overriding '/Zi' with '/Z7'
cl : Command line warning D9025 : overriding '/W2' with '/W3'
cl : Command line warning D9025 : overriding '/O1' with '/Od'
../src/v0.12.1-747f5d510c.clean/src/loaders/ttf/tvgTtfLoader.cpp(45): error C3861: 'CreateFileA': identifier not found
../src/v0.12.1-747f5d510c.clean/src/loaders/ttf/tvgTtfLoader.cpp(49): error C3861: 'GetFileSize': identifier not found

These functions aren't available for uwp apps.

@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Jan 16, 2024
@LilyWangLL
Copy link
Contributor

Feature tools passed on x64-windows.

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jan 17, 2024
@JavierMatosD JavierMatosD merged commit 74b5049 into microsoft:master Jan 17, 2024
15 checks passed
@rinechran rinechran deleted the thorvg_v0.12.1 branch January 22, 2024 16:44
Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
* update :  thorvg 0.12.1

* update : baseline update

* update : tools

* update : baseline

* update : not support uwp

* update : baseline
TomKatom pushed a commit to TomKatom/vcpkg that referenced this pull request Feb 23, 2024
* update :  thorvg 0.12.1

* update : baseline update

* update : tools

* update : baseline

* update : not support uwp

* update : baseline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants