Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libdatachannel] Delete the redundant dependency libSRTP in the config file #36191

Merged
merged 6 commits into from
Jan 19, 2024

Conversation

jimwang118
Copy link
Contributor

@jimwang118 jimwang118 commented Jan 16, 2024

Fixes #36177 #35863

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

All features passed with following triplets:

x86-windows
x64-windows

Usage test pass with following triplets:

x86-windows
x64-windows
x64-linux

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jan 16, 2024
@jimwang118 jimwang118 marked this pull request as ready for review January 16, 2024 07:08
MonicaLiu0311
MonicaLiu0311 previously approved these changes Jan 16, 2024
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Jan 16, 2024
@JavierMatosD
Copy link
Contributor

Please resolve the merge conflicts.

@JavierMatosD JavierMatosD marked this pull request as draft January 17, 2024 20:14
@jimwang118 jimwang118 marked this pull request as ready for review January 18, 2024 03:08
@JavierMatosD JavierMatosD merged commit 8c08848 into microsoft:master Jan 19, 2024
15 checks passed
Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
…g file (microsoft#36191)

* Fix libsrtp not found

* update version

* add dep

* update version

* update version
@jimwang118 jimwang118 deleted the fix_libdatachannel branch January 25, 2024 07:11
TomKatom pushed a commit to TomKatom/vcpkg that referenced this pull request Feb 23, 2024
…g file (microsoft#36191)

* Fix libsrtp not found

* update version

* add dep

* update version

* update version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libdatachannel] configure failure
3 participants