[qtbase] Add securetransport feature to build with SSL support on iOS #36286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should the default-features be modified, so that securetransport is enabled for ios and openssl is disabled for ios? |
dg0yt
reviewed
Jan 22, 2024
LilyWangLL
added
the
category:port-feature
|
@m-kuhn , your comment has been addressed. |
m-kuhn
reviewed
Jan 22, 2024
|
For the record, SecureTransport is considered legacy already and a new Network framework is inbound |
|
@nirvn |
|
@LilyWangLL , yes, it will be done within the next 24 hours |
|
@LilyWangLL , done. |
|
@nirvn Could you please resolve the conflicts? |
nirvn
force-pushed
the
qtbase_ios_ssl
branch
2 times, most recently
from
ab9e0df
to
50ef0ed
Compare
|
@Cheney-W , done, thanks for the heads up, hadn't noticed. |
|
@Cheney-W , @LilyWangLL , PR rebased once again to take care of the new conflict that arose. |
LilyWangLL
approved these changes
Jan 29, 2024
data-queue
approved these changes
Jan 30, 2024
TomKatom
pushed a commit
to TomKatom/vcpkg
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a secure transport feature to qtbase. The feature is needed when building on iOS to allow for SSL networking.