Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[allegro5] Update #36464

Merged
merged 5 commits into from
Jan 31, 2024
Merged

[allegro5] Update #36464

merged 5 commits into from
Jan 31, 2024

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jan 30, 2024 •
edited
Loading

Updates dependencies.
Fixes #36457. Fixes #35866.

@MonicaLiu0311 MonicaLiu0311 self-assigned this Jan 30, 2024
@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Jan 30, 2024
@dg0yt dg0yt marked this pull request as ready for review January 30, 2024 08:30
@MonicaLiu0311
Copy link
Contributor

All features are tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static

The usage test passed on x64-windows (header files found):

allegro5 provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(Allegro CONFIG REQUIRED)
  # note: 9 additional targets are not displayed.
  target_link_libraries(main PRIVATE Allegro::allegro Allegro::allegro_ttf Allegro::allegro_font Allegro::allegro_main)

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Jan 31, 2024
@FrankXie05 FrankXie05 mentioned this pull request Jan 31, 2024
Merged
7 tasks
@data-queue data-queue merged commit e07c955 into microsoft:master Jan 31, 2024
16 checks passed
@dg0yt dg0yt deleted the allegro5 branch February 1, 2024 05:06
TomKatom pushed a commit to TomKatom/vcpkg that referenced this pull request Feb 23, 2024
@dg0yt @TomKatom
[allegro5] Update (microsoft#36464)
4948052 
* [allegro5] Update to 5.2.9.1

* Remove allegro5 from CI baseline

* [allegro5] Fixup

* [allegro5] Fixup

* [allegro5] Fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomas1664 Thomas1664 Thomas1664 left review comments

@MonicaLiu0311 MonicaLiu0311 MonicaLiu0311 approved these changes

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[allegro5] Build error on x64-linux [allegro5] Build error on x64-linux
4 participants
@dg0yt @MonicaLiu0311 @Thomas1664 @data-queue