Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openssl] update to 3.2.1 #36560

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

carsten-grimm
Copy link
Contributor

Fixes #36477.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

The patches that were removed were no longer necessary, as their changes have been applied upstream.

@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Feb 4, 2024
@carsten-grimm carsten-grimm marked this pull request as ready for review February 4, 2024 17:47
@JonLiu1993
Copy link
Member

@carsten-grimm, thanks for the PR, when I test the feature via the command ./vcpkg install openssl[ssl3,tools,weak-ssl-ciphers]:x64-windows-static I get this error, please have a look :

install-x64-windows-static-rel-nmake-out.log
install-x64-windows-static-rel-nmake-err.log

@carsten-grimm
Copy link
Contributor Author

@carsten-grimm, thanks for the PR, when I test the feature via the command ./vcpkg install openssl[ssl3,tools,weak-ssl-ciphers]:x64-windows-static I get this error, please have a look :

install-x64-windows-static-rel-nmake-out.log install-x64-windows-static-rel-nmake-err.log

Thanks for checking this. I cannot replicate this on my machine; I can successfully install openssl with that particular set of features. I assume that you can reproduce the issue reliably?

crypto\asn1\libcrypto-lib-asn_mime.obj : fatal error LNK1136: invalid or corrupt file

This error is the only hint and it is something that I have not encountered, yet.

I will not be able to work on this today. In the meantime, any hints on this matter are welcome.

@JonLiu1993
Copy link
Member

@carsten-grimm, thanks for the PR, when I test the feature via the command ./vcpkg install openssl[ssl3,tools,weak-ssl-ciphers]:x64-windows-static I get this error, please have a look :
install-x64-windows-static-rel-nmake-out.log install-x64-windows-static-rel-nmake-err.log

Thanks for checking this. I cannot replicate this on my machine; I can successfully install openssl with that particular set of features. I assume that you can reproduce the issue reliably?

crypto\asn1\libcrypto-lib-asn_mime.obj : fatal error LNK1136: invalid or corrupt file

This error is the only hint and it is something that I have not encountered, yet.

I will not be able to work on this today. In the meantime, any hints on this matter are welcome.

If you have tested it locally, then I agree. It may be a problem with my test environment.

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Feb 6, 2024
@data-queue data-queue merged commit d83f4e9 into microsoft:master Feb 6, 2024
16 checks passed
TomKatom pushed a commit to TomKatom/vcpkg that referenced this pull request Feb 23, 2024
* [openssl] update to 3.2.1

* [openssl] remove patches that were applied upstream

* [openssl] regenerate version info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants