-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dcmtk] Fix dependencies #36607
Merged
Merged
[dcmtk] Fix dependencies #36607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimwang118
added
category:port-bug
The issue is with a library, which is something the port should already support
info:internal
This PR or Issue was filed by the vcpkg team.
labels
Feb 6, 2024
dg0yt
suggested changes
Feb 6, 2024
dcmtk isn't linking tiff correctly. dcmtk bug, not tiff bug. |
Mixing two similar implementations of jpeg (port libjpeg-turbo via port tiff, and a vendored copy in dcmtk) is asking for all kind of trouble. |
And port dcmtk even doesn't allow users to opt out from the dependencies' default features. |
dg0yt
reviewed
Feb 6, 2024
MonicaLiu0311
approved these changes
Feb 8, 2024
MonicaLiu0311
added
the
info:reviewed
Pull Request changes follow basic guidelines
label
Feb 8, 2024
TomKatom
pushed a commit
to TomKatom/vcpkg
that referenced
this pull request
Feb 23, 2024
* fix dep * update version * fix link * update vertsion * update version * fix patch * update version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-bug
The issue is with a library, which is something the port should already support
info:internal
This PR or Issue was filed by the vcpkg team.
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36509
Fix the method of finding
tiff
.Solve the problem of mixed use of jpeg (port libjpeg-turbo via port tiff, and a vendored copy in dcmtk).
SHA512s are updated for each updated download.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.Usage test pass with following triplets: