Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dcmtk] Fix dependencies #36607

Merged
merged 7 commits into from
Feb 8, 2024
Merged

[dcmtk] Fix dependencies #36607

merged 7 commits into from
Feb 8, 2024

Conversation

jimwang118
Copy link
Contributor

@jimwang118 jimwang118 commented Feb 6, 2024

Fixes #36509

Fix the method of finding tiff.

ld: Undefined symbols:
  _lzma_code, referenced from:
      _ in libtiff.a[24](tif_lzma.c.o)
      _LZMAPostEncode in libtiff.a[24](tif_lzma.c.o)
      _LZMAEncode in libtiff.a[24](tif_lzma.c.o)

Solve the problem of mixed use of jpeg (port libjpeg-turbo via port tiff, and a vendored copy in dcmtk).

duplicate symbol '_jpeg12_read_scanlines' in:
    /Users/vcpkg/jim/vcpkg/installed/arm64-osx/lib/libjpeg.a[24](jdapistd.c.o)
    lib/libijg12.a[29](jdapistd.c.o)
duplicate symbol '_jpeg16_read_scanlines' in:
    /Users/vcpkg/jim/vcpkg/installed/arm64-osx/lib/libjpeg.a[52](jdapistd.c.o)
    lib/libijg16.a[29](jdapistd.c.o)
duplicate symbol '_jpeg12_read_raw_data' in:
    /Users/vcpkg/jim/vcpkg/installed/arm64-osx/lib/libjpeg.a[24](jdapistd.c.o)
    lib/libijg12.a[29](jdapistd.c.o)
ld: 3 duplicate symbols
clang: error: linker command failed with exit code 1 (use -v to see invocation)
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Usage test pass with following triplets:

x64-windows
arm64-osx

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Feb 6, 2024
ports/tiff/Findlzma.patch Outdated Show resolved Hide resolved
@dg0yt
Copy link
Contributor

dg0yt commented Feb 6, 2024

ld: Undefined symbols:
  _lzma_code, referenced from:
      _ in libtiff.a[24](tif_lzma.c.o)
      _LZMAPostEncode in libtiff.a[24](tif_lzma.c.o)
      _LZMAEncode in libtiff.a[24](tif_lzma.c.o)

dcmtk isn't linking tiff correctly. dcmtk bug, not tiff bug.

@dg0yt
Copy link
Contributor

dg0yt commented Feb 6, 2024

Mixing two similar implementations of jpeg (port libjpeg-turbo via port tiff, and a vendored copy in dcmtk) is asking for all kind of trouble.

@dg0yt
Copy link
Contributor

dg0yt commented Feb 6, 2024

And port dcmtk even doesn't allow users to opt out from the dependencies' default features.

@jimwang118 jimwang118 marked this pull request as ready for review February 7, 2024 01:54
@jimwang118 jimwang118 marked this pull request as draft February 7, 2024 01:54
@jimwang118 jimwang118 marked this pull request as ready for review February 7, 2024 06:43
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Feb 8, 2024
@data-queue data-queue merged commit fe9f0b2 into microsoft:master Feb 8, 2024
16 checks passed
TomKatom pushed a commit to TomKatom/vcpkg that referenced this pull request Feb 23, 2024
* fix dep

* update version

* fix link

* update vertsion

* update version

* fix patch

* update version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dcmtk] Build failure on arm64-osx
4 participants