[opengl-registry/egl-registry] update #36856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonLiu1993
added
the
category:port-update
JonLiu1993
reviewed
Feb 20, 2024
| @@ -0,0 +1,28 @@ | |||
| ## include/KHR/khrplatform.h | |||
There was a problem hiding this comment.
@moritz-h, Thanks for your PR, do the two copyrights you added exist in the upstream source code? We do not recommend users to add copyright that does not exist in the upstream.
There was a problem hiding this comment.
The copyright text is directly copied from https://github.com/KhronosGroup/EGL-Registry/blob/main/api/KHR/khrplatform.h
The file paths I used as heading are from perspective of the installed port not in the source repo.
I know putting the copyright here is not a clean solution, but solving this for these repos is probably more complicated and worked on in #28644. So my goal was just update the ports and maybe make the copyright a little less broken than before, but I would still see this as workaround until the other PR is ready.
JonLiu1993
approved these changes
Feb 21, 2024
TomKatom
pushed a commit
to TomKatom/vcpkg
that referenced
this pull request
Feb 23, 2024
- [x] Changes comply with the [maintainer guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md). - [x] SHA512s are updated for each updated download. - [x] The "supports" clause reflects platforms that may be fixed by this new version. - [x] Any fixed [CI baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt) entries are removed from that file. - [x] Any patches that are no longer applied are deleted from the port's directory. - [x] The version database is fixed by rerunning `./vcpkg x-add-version --all` and committing the result. - [x] Only one version is added to each modified port's versions file. This PR updates the `opengl-registry` and `egl-registry` ports to the latest version. In addition both ports have broken copyright information as both repositories are using individual licenses for each file. I tried to fix this by including a vendored copyright file for the `egl-registry` port. For `opengl-registry` I have just included a note that all files are individually licensed. A proper fix for this seems to be already worked on in microsoft#28644.
Osyotr
pushed a commit
to Osyotr/vcpkg
that referenced
this pull request
Feb 26, 2024
- [x] Changes comply with the [maintainer guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md). - [x] SHA512s are updated for each updated download. - [x] The "supports" clause reflects platforms that may be fixed by this new version. - [x] Any fixed [CI baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt) entries are removed from that file. - [x] Any patches that are no longer applied are deleted from the port's directory. - [x] The version database is fixed by rerunning `./vcpkg x-add-version --all` and committing the result. - [x] Only one version is added to each modified port's versions file. This PR updates the `opengl-registry` and `egl-registry` ports to the latest version. In addition both ports have broken copyright information as both repositories are using individual licenses for each file. I tried to fix this by including a vendored copyright file for the `egl-registry` port. For `opengl-registry` I have just included a note that all files are individually licensed. A proper fix for this seems to be already worked on in microsoft#28644.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.This PR updates the
opengl-registryandegl-registryports to the latest version. In addition both ports have broken copyright information as both repositories are using individual licenses for each file. I tried to fix this by including a vendored copyright file for theegl-registryport. Foropengl-registryI have just included a note that all files are individually licensed. A proper fix for this seems to be already worked on in #28644.