-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gstreamer] update to 1.24.1 #37392
base: master
Are you sure you want to change the base?
[gstreamer] update to 1.24.1 #37392
Conversation
- subproject('win-nasm') | ||
-elif build_system == 'darwin' | ||
- subproject('macos-bison-binary') | ||
-if get_option('build-tools-source') == 'subproject' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using meson option build-tools-source=system
perhaps take effect as well,But I'm not sure what the side effects would be
9c4c44c
to
f470a07
Compare
@WangWeiLin-MV I have tested on ubuntu with triplit x64-linux, unable to find the error the ci-server report. I have no ios device, so can't test on it.
|
1da5bbf
to
9d0e982
Compare
9d0e982
to
f98ff97
Compare
What's left to get this through? |
ci said qtframework incompatible with gstreamer 1.24 with full-static-compile. But I have tried it in my linux computer, it works. |
looks like this is the relevant excerpt from the logs
|
I know it. I have check the ci log. But I can not reproduce this error in my linux computer, so I don't know how to fix it. Currently I use gstreamer 1.24.1 by overlay port. |
Since it's a linking issue, it might be hidden by an OS installed GStreamer version, I couldn't reproduce either but I'll try in a container.
EDIT: It's not |
I think you need "dependencies": [
"qt"
] So that |
Looks like this is the issue, |
NO, never depend on (ALL of) qt. |
"dependencies": [
{
"name": "qtmultimedia",
"default-features": false,
"features": [
"gstreamer"
],
},
"qtinterfaceframework"
] this should equivalent if you like |
perhaps |
My previous guess was the same, but I can't understand the qt build system, and there's nothing I can do to modify qt's portfile, and on the other hand I'm not sure if qt needs to link to gstreamer-full-1.0 just to build a gstreamer plugin. but I'm locally static linking with gstreamer-full-1.0 in static linkage mode and have had no problems so far. When linking gstreamer-1.0 before, all the tools didn't work. I've posted a thread in the gstreamer forum asking about the difference between gstreamer-1.0 and gstreamer-full-1.0, and no one has replied to me so far! |
It sounded like from my brief look that I played around with adding As an aside If I get time in the coming weeks I'll take a stab at this again. |
@gerard-ryan-immersaview Personally, I feel that this is a bug of gstreamer full-static feature, Gstreamer-1.0.a does not work well after enabling the full-static feature. I have asked for help in the gstreamer forum, but no one has replied to me so far. |
you could be right! the only cause for question that makes me consider |
gstreamer-full-1.0 seems to be a convenience lib which doesn't only include gstreamer libs and plugins. README: "glib-2.0, gobject-2.0 and gstreamer-1.0 are always included." That's indeed convenient for tools, but probably not what should be used in other vcpkg ports. AFAICS the new full-static option makes the gstreamer lib call So this is really a dilemma for static library linkage: You either get too much, or not enough. IMO if lib gstreamer-full-1.0 really includes lib gstreamer, it should have a variant with plugin initialization without forcing implementation details on direct users of lib gstreamer. |
./vcpkg x-add-version --all
and committing the result.I was going to change the dependency version of vcpkg-tool-meson to
"version>=": 1.1.0
, but found that vcpkg wouldn't find an available version of meson as a result, even though the latest meson is 1.3.2