Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qt5-webengine] Depend on atl instead of atlmfc #37626

Merged

Conversation

tsondergaard
Copy link
Contributor

qt5-webengine only requires atl, it does not use mfc. Switching to just atl means installations of Visual Studio and Visual Studio Build Tools do not need to explicitly include
Microsoft.VisualStudio.Component.VC.ATLMFC.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

qt5-webengine only requires atl, it does not use mfc. Switching to
just atl means installations of Visual Studio and Visual Studio Build
Tools do not need to explicitly include
Microsoft.VisualStudio.Component.VC.ATLMFC.
@BillyONeal
Copy link
Member

BillyONeal commented Mar 23, 2024

This matches the documentation at https://doc.qt.io/Qt-5/qtwebengine-platform-notes.html#windows

Thanks!

@BillyONeal BillyONeal merged commit 18696a5 into microsoft:master Mar 23, 2024
16 checks passed
@tsondergaard tsondergaard deleted the qt5-webengine-drop-mfc-dependency branch March 23, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants