-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qscintilla] Add CMake export #37787
[qscintilla] Add CMake export #37787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The config and target must take care of all usage requirements. When I look at share/Qt6/mkspecs/features/qscintilla2.prf, I see: Qt Widgets and (except for ios) PrintSupport.
I'm sorry, I don't quite understand. Are you asking if there are other situations where the installed library has a different name? |
No, I think that linking the target with location properties will not be enough with static libary linkage (if actually using a symbol from the lib). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now but I didn't test. Someone else must approve.
Thanks @LilyWangLL.
Thanks for your help. I have tested the usage after changes, it passed on |
Fixes #36817
Usage test passed on
x64-windows
andx64-windows-static
.SHA512s are updated for each updated download.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.