Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qscintilla] Add CMake export #37787

Merged
merged 9 commits into from
Apr 11, 2024

Conversation

LilyWangLL
Copy link
Contributor

Fixes #36817
Usage test passed on x64-windows and x64-windows-static.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@LilyWangLL LilyWangLL added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Mar 28, 2024
@LilyWangLL LilyWangLL marked this pull request as ready for review March 28, 2024 09:27
Cheney-W
Cheney-W previously approved these changes Mar 29, 2024
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Mar 29, 2024
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config and target must take care of all usage requirements. When I look at share/Qt6/mkspecs/features/qscintilla2.prf, I see: Qt Widgets and (except for ios) PrintSupport.

@LilyWangLL
Copy link
Contributor Author

The config and target must take care of all usage requirements. When I look at share/Qt6/mkspecs/features/qscintilla2.prf, I see: Qt Widgets and (except for ios) PrintSupport.

I'm sorry, I don't quite understand. Are you asking if there are other situations where the installed library has a different name?

@Cheney-W Cheney-W removed the info:reviewed Pull Request changes follow basic guidelines label Mar 29, 2024
@dg0yt
Copy link
Contributor

dg0yt commented Mar 30, 2024

No, I think that linking the target with location properties will not be enough with static libary linkage (if actually using a symbol from the lib).
(That's why there are wrappers and unofficial CMake config in 1000 other ports: Populate INTERFACE_LINK_LIBRARIES.)

@LilyWangLL LilyWangLL requested a review from dg0yt April 10, 2024 02:01
ports/qscintilla/portfile.cmake Outdated Show resolved Hide resolved
ports/qscintilla/unofficial-qscintilla-config.cmake Outdated Show resolved Hide resolved
ports/qscintilla/unofficial-qscintilla-config.cmake Outdated Show resolved Hide resolved
ports/qscintilla/unofficial-qscintilla-config.cmake Outdated Show resolved Hide resolved
ports/qscintilla/unofficial-qscintilla-config.cmake Outdated Show resolved Hide resolved
@LilyWangLL LilyWangLL marked this pull request as ready for review April 10, 2024 09:22
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now but I didn't test. Someone else must approve.

Thanks @LilyWangLL.

@LilyWangLL
Copy link
Contributor Author

LGTM now but I didn't test. Someone else must approve.

Thanks @LilyWangLL.

Thanks for your help. I have tested the usage after changes, it passed on x64-windows.

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Apr 11, 2024
@JavierMatosD JavierMatosD merged commit 43d8179 into microsoft:master Apr 11, 2024
16 checks passed
@LilyWangLL LilyWangLL deleted the dev/LilyWang/issue36817 branch May 29, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[qscintilla] No CMake targets are defined
4 participants