Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[etcd-cpp-apiv3] Update, cleanup #37908

Merged
merged 1 commit into from
Apr 2, 2024
Merged

[etcd-cpp-apiv3] Update, cleanup #37908

merged 1 commit into from
Apr 2, 2024

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Apr 1, 2024 •
edited
Loading

Fix build with Android NDK r26.

@Cheney-W Cheney-W added category:port-update The issue is with a library, which is requesting update new revision category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. labels Apr 2, 2024
@dg0yt dg0yt marked this pull request as ready for review April 2, 2024 06:23
@Cheney-W
Copy link
Contributor

Cheney-W commented Apr 2, 2024

Usage passed with x64-windows triplet.

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Apr 2, 2024
@BillyONeal BillyONeal merged commit ba5364d into microsoft:master Apr 2, 2024
16 checks passed
@BillyONeal
Copy link
Member

Thanks!

@dg0yt dg0yt deleted the etc branch April 2, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cheney-W Cheney-W Cheney-W approved these changes

Assignees

@Cheney-W Cheney-W

Labels
category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dg0yt @Cheney-W @BillyONeal