Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qtbase] Fix "There should be no absolute paths" #37986

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

bansan85
Copy link
Contributor

@bansan85 bansan85 commented Apr 5, 2024

Problem occurs on x64-linux-dynamic.

warning: There should be no absolute paths, such as the following, in an installed package:
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic
  /home/XXX/prog/vcpkg/installed
  /home/XXX/prog/vcpkg/buildtrees/qtbase
  /home/XXX/prog/vcpkg/downloads
Absolute paths were found in the following files:
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/debug/lib/pkgconfig/Qt6Concurrent.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/debug/lib/pkgconfig/Qt6Core.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/debug/lib/pkgconfig/Qt6DBus.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/debug/lib/pkgconfig/Qt6Gui.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/debug/lib/pkgconfig/Qt6Network.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/debug/lib/pkgconfig/Qt6OpenGL.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/debug/lib/pkgconfig/Qt6OpenGLWidgets.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/debug/lib/pkgconfig/Qt6Platform.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/debug/lib/pkgconfig/Qt6PrintSupport.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/debug/lib/pkgconfig/Qt6Sql.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/debug/lib/pkgconfig/Qt6Test.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/debug/lib/pkgconfig/Qt6Widgets.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/debug/lib/pkgconfig/Qt6Xml.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/lib/pkgconfig/Qt6Concurrent.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/lib/pkgconfig/Qt6Core.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/lib/pkgconfig/Qt6DBus.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/lib/pkgconfig/Qt6Gui.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/lib/pkgconfig/Qt6Network.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/lib/pkgconfig/Qt6OpenGL.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/lib/pkgconfig/Qt6OpenGLWidgets.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/lib/pkgconfig/Qt6Platform.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/lib/pkgconfig/Qt6PrintSupport.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/lib/pkgconfig/Qt6Sql.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/lib/pkgconfig/Qt6Test.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/lib/pkgconfig/Qt6Widgets.pc
  /home/XXX/prog/vcpkg/packages/qtbase_x64-linux-dynamic/lib/pkgconfig/Qt6Xml.pc
error: Found 1 post-build check problem(s). To submit these ports to curated catalogs, please first correct the portfile: /home/XXX/prog/vcpkg/ports/qtbase/portfile.cmake
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Neumann-A
Copy link
Contributor

Move that call into the qt script helpers.

@bansan85 bansan85 marked this pull request as draft April 5, 2024 07:44
@bansan85 bansan85 marked this pull request as ready for review April 5, 2024 09:14
@bansan85
Copy link
Contributor Author

bansan85 commented Apr 5, 2024

I didn't tested every Qt packages but I don't have anymore error.

@Neumann-A
Copy link
Contributor

please move it into qt_fixup_and_cleanup

Problem occurs on x64-linux-dynamic with qtbase, qtshadertools,
qtdeclarative, qt3d, qt5compat, ...
@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. labels Apr 7, 2024
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Apr 8, 2024
@JavierMatosD JavierMatosD merged commit 7af039c into microsoft:master Apr 9, 2024
16 checks passed
@bansan85 bansan85 deleted the qtbase branch April 10, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants