[many ports] Don't depend on default features of tiff #38049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate #38047? |
Thomas1664
changed the title
Probably should have checked beforehand. But why stopping there? |
WangWeiLin-MV
added
the
category:port-feature
Because #38047 revises all dependencies in one port, instead of one dep in many ports. This reduces overlap with other (people's) PRs. |
I will remove the changes to freeimage. However, I don't think it makes sense to open one PR per port because this would take like 30+ PRs. |
dg0yt
reviewed
Apr 9, 2024
|
@WangWeiLin-MV this PR is ready for review. |
|
Please resolve conflicts. |
WangWeiLin-MV
previously approved these changes
Apr 26, 2024
WangWeiLin-MV
added
the
info:reviewed
data-queue
approved these changes
May 2, 2024
yurybura
pushed a commit
to yurybura/vcpkg
that referenced
this pull request
May 8, 2024
This removes the transitive dependency of liblzma via tiff - [x] Changes comply with the [maintainer guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md). - [x] SHA512s are updated for each updated download. - [x] The "supports" clause reflects platforms that may be fixed by this new version. - [x] Any fixed [CI baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt) entries are removed from that file. - [x] Any patches that are no longer applied are deleted from the port's directory. - [x] The version database is fixed by rerunning `./vcpkg x-add-version --all` and committing the result. - [x] Only one version is added to each modified port's versions file. --------- Co-authored-by: Alexander Neumann <30894796+Neumann-A@users.noreply.github.com> Co-authored-by: Alexander Neumann <you@example.com> Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the transitive dependency of liblzma via tiff
./vcpkg x-add-version --alland committing the result.