Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[krb5] Fix relative path fixup #38972

Merged
merged 1 commit into from
May 29, 2024
Merged

[krb5] Fix relative path fixup #38972

merged 1 commit into from
May 29, 2024

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented May 28, 2024

  • Fix unsuitable substitution ($(pwd) in single quotes).
  • Fix wrong substitution in debug variant.

@dg0yt
Copy link
Contributor Author

dg0yt commented May 28, 2024

/mnt/vcpkg-ci/b/kf5kio/src/v5.98.0-1c8192d833.clean/cmake/FindGSSAPI.cmake(35):  exec_program(/mnt/vcpkg-ci/installed/x64-linux/tools/krb5/bin/krb5-config ARGS --libs gssapi RETURN_VALUE _return_VALUE OUTPUT_VARIABLE GSSAPI_LIBS )
CMake Warning (dev) at cmake/FindGSSAPI.cmake:35 (exec_program):
  Policy CMP0153 is not set: The exec_program command should not be called.
  Run "cmake --help-policy CMP0153" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  Use execute_process() instead.
Call Stack (most recent call first):
  /mnt/vss/_work/1/s/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
  CMakeLists.txt:113 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

/mnt/vcpkg-ci/b/kf5kio/src/v5.98.0-1c8192d833.clean/cmake/FindGSSAPI.cmake(36):  if(_return_VALUE )
/mnt/vcpkg-ci/b/kf5kio/src/v5.98.0-1c8192d833.clean/cmake/FindGSSAPI.cmake(41):  exec_program(/mnt/vcpkg-ci/installed/x64-linux/tools/krb5/bin/krb5-config ARGS --cflags gssapi RETURN_VALUE _return_VALUE OUTPUT_VARIABLE GSSAPI_INCS )
CMake Warning (dev) at cmake/FindGSSAPI.cmake:41 (exec_program):
  Policy CMP0153 is not set: The exec_program command should not be called.
  Run "cmake --help-policy CMP0153" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  Use execute_process() instead.
Call Stack (most recent call first):
  /mnt/vss/_work/1/s/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
  CMakeLists.txt:113 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

/mnt/vcpkg-ci/b/kf5kio/src/v5.98.0-1c8192d833.clean/cmake/FindGSSAPI.cmake(42):  string(REGEX REPLACE (
?
)+$  GSSAPI_INCS -I$(pwd)/../../..//include )
/mnt/vcpkg-ci/b/kf5kio/src/v5.98.0-1c8192d833.clean/cmake/FindGSSAPI.cmake(43):  string(REGEX REPLACE  *-I ; GSSAPI_INCS -I$(pwd)/../../..//include )

@MonicaLiu0311 MonicaLiu0311 added the category:port-bug The issue is with a library, which is something the port should already support label May 28, 2024
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label May 28, 2024
@vicroms vicroms merged commit 9af6fa5 into microsoft:master May 29, 2024
17 checks passed
@dg0yt dg0yt deleted the krb5-config branch May 29, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants