Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-sdk-cpp] Fix linking issue when using MinGW #39064

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

fwosar
Copy link
Contributor

@fwosar fwosar commented May 31, 2024

It appears like the aws-sdk-cpp maintainers, in an attempt to avoid a warning when compiling with Visual Studio, opted to use a Microsoft-only function for reading environment variables. As a result, linking the library will fail in MinGW environments. This PR adds a patch to aws-sdk-cpp port that will replace the non-standard function with a standard compliant version when being compiled for Windows using a non-Microsoft compiler.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Cheney-W Cheney-W added the category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. label Jun 3, 2024
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jun 3, 2024
@vicroms vicroms merged commit 283f99c into microsoft:master Jun 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants