[x265] fix android library build #39314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg0yt
reviewed
Jun 16, 2024
LilyWangLL
added
the
category:port-feature
|
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags. |
fix homepage Co-authored-by: Kai Pastor <dg0yt@darc.de>
|
Please fix the CI error as below message: |
dg0yt
reviewed
Jun 22, 2024
Comment on lines
+9
to
+12
| - list(APPEND PLATFORM_LIBS pthread) | ||
| + if(NOT ANDROID) | ||
| + list(APPEND PLATFORM_LIBS pthread) | ||
| + endif() |
There was a problem hiding this comment.
The proper fix is to properly provide the flags as needed and available from FindThreads.cmake. And this must also go to the pc file. I think I will create an alternative PR.
There was a problem hiding this comment.
cool, I will close this PR if your PR merged
BillyONeal
pushed a commit
that referenced
this pull request
Jun 25, 2024
Fixes build errors on android due to wrong pthread flags and 32 bit API level requirements (`ftello`). Alternative to #39314.
|
Closing this PR at your request in #39314 (comment) . Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ √] Changes comply with the maintainer guide.
[ √] SHA512s are updated for each updated download.
[ √] The "supports" clause reflects platforms that may be fixed by this new version.
[ √] Any fixed CI baseline entries are removed from that file.
[√ ] Any patches that are no longer applied are deleted from the port's directory.
[√ ] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[ √] Only one version is added to each modified port's versions file.