Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gdal] update port to 2.3.2 and mysql support as port feature #4413

Merged
merged 3 commits into from
Oct 12, 2018

Conversation

hlysunnaram
Copy link
Contributor

@hlysunnaram hlysunnaram commented Oct 5, 2018

This PR updates gdal port from 2.3.0 to 2.3.2.

It also removes libmysql from GDAL core dependencies and makes mysql support a port feature (related issue: #3793).

Two features are created:

  • mysql-libmysql to add mysql support using libmysql
  • mysql-libmariadb to add mysql support using libmariadb

mysql-libmysql is placed in Default-Features to keep previous compatibility.
However, one can choose between libmariadb or libmysql implementation or even no mysql support using feature selection:

vcpkg install gdal[core]
vcpkg install gdal[core,mysql-libmysql]
vcpkg install gdal[core,mysql-libmariadb]

Finally, this PR fixes build issue of libmariadb if VCPKG_BUILD_TYPE is set to release or debug

@hlysunnaram hlysunnaram changed the title [gdal] update port to 2.3.2 and mysql as port feature [gdal] update port to 2.3.2 and mysql support as port feature Oct 5, 2018
Herve Ly-Sunnaram added 3 commits October 9, 2018 09:15
* create new port features: mysql-libmysql and mysql-libmariadb
* add mysql-libmysql as default feature: to build on x86, install gdal[core] or gdal[core,mysql-libmariadb] if mysql support is needed
@ras0219-msft ras0219-msft merged commit 38c741f into microsoft:master Oct 12, 2018
@ras0219-msft
Copy link
Contributor

Awesome, thanks for the PR!

@hlysunnaram hlysunnaram deleted the update/gdal-2.3.2 branch October 16, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants