Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libjpeg-turbo] use d suffix for debug libs #4965

Merged
merged 6 commits into from
Jan 11, 2019

Conversation

cenit
Copy link
Contributor

@cenit cenit commented Dec 13, 2018

Using the d suffix in debug, it allows the official (cmake 3.13) FindJPEG to correctly find the two different configuration libraries

@Rastaban Rastaban self-assigned this Dec 14, 2018
@Rastaban
Copy link
Contributor

I am seeing failures in qt5-base on windows, it may need updated to find the new debug library name.

@cenit
Copy link
Contributor Author

cenit commented Dec 20, 2018

very glad that you can find regressions and failures in other ports.
Shall I check qt5-base also?

@Rastaban
Copy link
Contributor

@cenit it would be great if you would be able to look into the qt5-base build failure.

@cenit
Copy link
Contributor Author

cenit commented Dec 21, 2018

ok sure, I'll try my best. Starting a build right now

@cenit
Copy link
Contributor Author

cenit commented Dec 21, 2018

ok I should have fixed the problem, please let me know if you find any other problem

@Rastaban Rastaban merged commit 885ca2c into microsoft:master Jan 11, 2019
@cenit cenit deleted the dev/cenit/libjpeg-debug branch March 7, 2019 13:32
@NancyLi1013
Copy link
Contributor

@cenit
Can we handle this via vcpkg-cmake-wrapper to solve this issue?

Since we recommend to use the name that upstream supports instead of renaming it.

Also this will block pkgconfig fixup. So I'm not sure which solution is more suitable.

What do you think?

@cenit
Copy link
Contributor Author

cenit commented Sep 3, 2020

That's the name that's most convenient for debug, and in fact the official cmake module looks for the d suffix... Maybe we can use a patch in the source code instead of renaming it after build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants