-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libjpeg-turbo] use d suffix for debug libs #4965
Conversation
I am seeing failures in qt5-base on windows, it may need updated to find the new debug library name. |
very glad that you can find regressions and failures in other ports. |
@cenit it would be great if you would be able to look into the qt5-base build failure. |
ok sure, I'll try my best. Starting a build right now |
ok I should have fixed the problem, please let me know if you find any other problem |
@cenit Since we recommend to use the name that upstream supports instead of renaming it. Also this will block pkgconfig fixup. So I'm not sure which solution is more suitable. What do you think? |
That's the name that's most convenient for debug, and in fact the official cmake module looks for the d suffix... Maybe we can use a patch in the source code instead of renaming it after build? |
Using the d suffix in debug, it allows the official (cmake 3.13) FindJPEG to correctly find the two different configuration libraries