Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libxml2] Update to 2.9.9 #5193

Merged
merged 11 commits into from
Mar 15, 2019
Merged

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented Jan 20, 2019

Fix #5177

@myd7349 myd7349 force-pushed the libxml2-2.9.9 branch 4 times, most recently from 3da9b08 to 422e1f9 Compare January 20, 2019 08:59
@myd7349
Copy link
Contributor Author

myd7349 commented Jan 31, 2019

I am tring to rewrite the port file with vcpkg_from_github: myd7349@31a7ea2.

  1. libxml2 downloaded from ftp://xmlsoft.org/libxml2/libxml2-2.9.4.tar.gz or http://xmlsoft.org/sources/libxml2-2.9.4.tar.gz already contains xmlversion.h.

    After switching to vcpkg_from_github, we have to config xmlversion.h.in by ourselves.

  2. libxml2 downloaded from ftp://xmlsoft.org/libxml2/libxml2-2.9.4.tar.gz or http://xmlsoft.org/sources/libxml2-2.9.4.tar.gz doesn't contain rngparser.c. And the build failed with this file. So I excluded this file from the sources list.

@myd7349
Copy link
Contributor Author

myd7349 commented Feb 14, 2019

@Codiferous
Copy link
Contributor

@myd7349 Sorry for the delay in processing this PR. We're seeing failures in the CI with this change, but I don't think it's the fault of this PR. I believe something else is going on. It's taking some time to investigate the issues.

The issues we're seeing look exactly like the errors here on macOS. I haven't been able to find a uuid.h that collides with the system provided one, so we're still trying to figure out where the issue is coming from.

@myd7349
Copy link
Contributor Author

myd7349 commented Feb 22, 2019

@Codiferous Thanks for the reply! I didn't test it on Mac(Because I don't have a Mac book 😄).

@Codiferous Codiferous removed their assignment Feb 25, 2019
@ras0219-msft ras0219-msft self-assigned this Feb 26, 2019
@myd7349
Copy link
Contributor Author

myd7349 commented Mar 9, 2019

UWP support:

  1. Failed to install liblzma on UWP: [liblzma] Fix for UWP build #5607

  2. Link errors:

    Creating library E:/vcpkg/buildtrees/libxml2/x86-uwp-dbg/Debug/libxml2.lib and object E:/vcpkg/buildtrees/libxml2/x86-uwp-dbg/Debug/libxml2.exp
    4>catalog.obj : error LNK2019: unresolved external symbol _GetModuleHandleA@4 referenced in function _xmlInitializeCatalog [E:\vcpkg\buildtrees\libxml2\x86-uwp-dbg\libxml2.vcxproj]
    4>xmlmodule.obj : error LNK2019: unresolved external symbol _LoadLibraryA referenced in function _xmlModulePlatformOpen [E:\vcpkg\buildtrees\libxml2\x86-uwp-dbg\libxml2.vcxproj]
    4>E:\vcpkg\buildtrees\libxml2\x86-uwp-dbg\Debug\libxml2.dll : fatal error LNK1120: 2 unresolved externals [E:\vcpkg\buildtrees\libxml2\x86-uwp-dbg\libxml2.vcxproj]

@ras0219-msft
Copy link
Contributor

Thanks for the PR!

I'm going to go ahead and merge this for now even though we're still waiting on the other PR to add UWP support. If there ends up being some remaining work to do for libxml2 after #5607, we can address that with a follow up :)

@ras0219-msft ras0219-msft merged commit 68a2b4c into microsoft:master Mar 15, 2019
@myd7349 myd7349 deleted the libxml2-2.9.9 branch March 15, 2019 23:39
@myd7349
Copy link
Contributor Author

myd7349 commented Mar 15, 2019

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants