[amqpcpp] Add new port #5201
Merged
[amqpcpp] Add new port #5201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation for this library says that shared linkage on Windows is unsupported. Furthermore, the build currently errors out on Windows because shared DLLs are not placed correctly. vcpkg only supports static linkage on Linux and macOS, so I'm categorically making amqpcpp build with static linkage on all platforms. This unifies the platforms and gives consistent behavior
|
This change looks good after applying the static linkage change. I'm going to merge this. Thanks for this PR! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Linux only.