-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update qt5 to 5.12.1 and add some missing modules #5293
Conversation
thinking about using features for the qt5 port instead of putting everything in as default. What do you think? |
Could you, please, explain? |
@Zingam sure :) I would split the qt5 port into features like quick, web, GUI, plugins so that when you install qt5 only the base is installed and not the whole framework. The other modules are installed via features or by specifying them like it is now. So the qt[quick] for example would include qt5-base, qt5-declarative, qt5-quickcontrols and qt5-quickcontrols2. |
Sounds great! What about Web related stuff? |
@Zingam some modules are still not working and I currently don't know how to get them to work if that's what you mean. So the web feature would be a thing for the future with webengine and other related modules. |
Excellent job @TheScarfix! Looks like there are no regressions, so I'll merge this PR.
|
Missing QtWebEngine. If you can successfully get Qt to 5.12.4 then I might consider sharing my port if there is any interest. |
still missing are androidextras, macextras, x11extras, webengine, webglplugin, webview, serialbus.
Also still fixing the Linux error, got to SQLite working. PSQL is still broken (but qt is not failing because of it now) and OpenGL libraries are needed on Linux (thinking about making it a dependency but I don't know how to check for installed packages)