Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build glib on x86-linux #5313

Merged
merged 6 commits into from
Mar 1, 2019
Merged

Build glib on x86-linux #5313

merged 6 commits into from
Mar 1, 2019

Conversation

koprok
Copy link
Contributor

@koprok koprok commented Feb 6, 2019

Changes to build glib on x86-linux target. The following triplet file has been used for the build:

set(VCPKG_TARGET_ARCHITECTURE x86)
set(VCPKG_CRT_LINKAGE dynamic)
set(VCPKG_LIBRARY_LINKAGE static)

set(VCPKG_CMAKE_SYSTEM_NAME Linux)

set(VCPKG_C_FLAGS "-m32")
set(VCPKG_CXX_FLAGS "-m32")
set(VCPKG_LINKER_FLAGS "-m32")

@ras0219-msft
Copy link
Contributor

Thank for the PR! LGTM pending CI.

We generally try to make the CMake files as vcpkg-independent as possible, so I've pulled some of the CFLAGS detection logic over from our boost wrapper[1] which should be more robust :)

[1] https://github.com/Microsoft/vcpkg/blob/6509199a2aeb882c91babb7cc95ef36b30738091/ports/boost-modular-build-helper/CMakeLists.txt#L44-L60

@vicroms vicroms merged commit 1afa2b0 into microsoft:master Mar 1, 2019
@vicroms
Copy link
Member

vicroms commented Mar 1, 2019

Thanks for the PR!
It passes all CI tests! 🎉

@koprok koprok deleted the x86-linux branch April 8, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants