Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qt5-base] Fix hardcoded and wrong absolute paths in Qt5Core.dll #5456

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

claudiofantacci
Copy link
Contributor

This PR changes the configuration parameters for the qt5-base port in order to fix #5455.

This reverts the reverting commit 473d63c#diff-ae2ab5cd22202159887c7d80ea952a4e as described in #5455.

Fixes #5455

@bouffa
Copy link

bouffa commented Mar 5, 2019

With this pull request, qmake.exe is no longer installed into (vcpkg_root)/packages/qt5-base_(triplet)/tools/qt5 folder, but directly to the (vcpkg_root)/installed/(triplet)/tools/qt5 .

This will make the vcpkg export command export a qt5-base package without qmake.exe, making it broken.

@bouffa
Copy link

bouffa commented Mar 5, 2019

The problem could not be limited to qmake.exe executable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qt5Core.dll built with absolute paths
3 participants