Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[darknet/yolo] new port #5648

Merged
merged 4 commits into from
Mar 14, 2019
Merged

[darknet/yolo] new port #5648

merged 4 commits into from
Mar 14, 2019

Conversation

cenit
Copy link
Contributor

@cenit cenit commented Mar 12, 2019

We finished a big rework of darknet to make it more easily buildable on windows. It is possible now to build it with vcpkg without any big effort.
The port is still very much untested, but we can iterate quickly on it also from the repository point of view, not just on this portfile.
Any suggestion is really appreciated and any issue will be taken into consideration

@vicroms
Copy link
Member

vicroms commented Mar 12, 2019

Hi @cenit

Thanks for the port!

I see failures on UWP and ARM because pthreads fails to build on those platforms.

The current pthreads port is using a no-longer-mantained library pthreads-w32, but I haven't got around updating it to pthreads4w. Aside from the discussion of whether the package should be findable by find_package(pthreads4w) instead of just find_package(pthreads)....

If you're OK with no support for UWP and ARM, please add a validation with an explicit failure message "darknet doesn't support UWP/ARM".

Another thing, I got file conflicts with stb when installing locally:

Building package darknet[core,weights]:x64-windows... done
Installing package darknet[core,weights]:x64-windows...
The following files are already installed in D:/github/vcpkg/installed/x64-windows and are in conflict with darknet:x64-windows
    include/stb_image.h
    include/stb_image_write.h

PS D:\github\vcpkg> ./vcpkg owns stb_image.h
stb:x64-windows: x64-windows/include/stb_image.h

@cenit
Copy link
Contributor Author

cenit commented Mar 12, 2019

Hi @vicroms
Thanks for the quick feedback. I will add an explicit failure message for uwp/arm and I will also try to use stb from vcpkg in the port. It should be almost fully compatible, I think it’s the best option going forward.
Next step will also be an update to pthread, but in another PR.

@vicroms vicroms self-assigned this Mar 12, 2019
@cenit
Copy link
Contributor Author

cenit commented Mar 13, 2019

I forgot to add an explicit failure message for uwp/arm, will do it asap

@vicroms vicroms merged commit cfdc331 into microsoft:master Mar 14, 2019
@cenit cenit deleted the dev/cenit/yolo branch March 20, 2019 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants