[pcre2/caffe2] Fix space issue #5827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rastaban
reviewed
Mar 27, 2019
ports/pcre2/portfile.cmake
Outdated
| @@ -8,6 +8,9 @@ vcpkg_download_distfile(ARCHIVE | |||
|
|
|||
| vcpkg_extract_source_archive(${ARCHIVE}) | |||
There was a problem hiding this comment.
switch this to vcpkg_extract_source_archive_ex and use the PATCHES argument to combine it with the vcpkg_apply_patches function call.
There was a problem hiding this comment.
@Rastaban Thanks for you suggestion. Fixed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These 2 ports failed with space path when installing in our testing.
[pcre2] There was a patch for the space issue previously, but put the patch to the wrong place in portfile.camke. It should be patched after extract source. Updates!
[caffe2]Failed with link error lNK1104 when linking lib files. Add "" to fix this issue.