[libuuid]Add warning to non-unix platform when building. #5844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 27, 2019 06:38
This reverts commit a833bf5.
|
What about macOS(Darwin)? |
Rastaban
reviewed
Mar 28, 2019
vicroms
requested changes
Mar 28, 2019
|
The change to azure-storage-cpp causes a build failure on Mac, working on a patch for the port to use the header that is part of the OS SDK. |
We recommend using the built in uuid.h on osx, but for now won't disallow the use of the libuuid port.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reviewing the issue #3852, I found that there are many Linux functions in the source code. Obviously libuuid does not support non-Linux systems, so I added a warning that it will fail directly when buiding under non-Linux systems.