Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libwebp] do not include all feature by default #5886

Merged
merged 2 commits into from
Apr 2, 2019
Merged

[libwebp] do not include all feature by default #5886

merged 2 commits into from
Apr 2, 2019

Conversation

kiwixz
Copy link
Contributor

@kiwixz kiwixz commented Mar 31, 2019

Currently vcpkg install libwebp will try to install these packages:

  * freeglut[core]:x64-windows
  * giflib[core]:x64-windows
  * libjpeg-turbo[core]:x64-windows
  * liblzma[core]:x64-windows
  * libpng[core]:x64-windows
    libwebp[all,core]:x64-windows
  * opengl[core]:x64-windows
  * sdl1[core]:x64-windows
  * tiff[core]:x64-windows
  * zlib[core]:x64-windows

I dont think that a reasonable default. If a user really wants everything, he should install libwebp[all].

@cenit
Copy link
Contributor

cenit commented Apr 1, 2019

There were many problems with the “bare” port, that’s why I made “all” the default feature. At the same time, having the option to reduce building was very interesting to expose.

@NancyLi1013
Copy link
Contributor

Hi @kiwixz, Please also update the CONTROL version. Thanks. I notice that it is 1.0.2-1 now and you can modify it as 1.0.2-2.

@kiwixz
Copy link
Contributor Author

kiwixz commented Apr 2, 2019

@NancyLi1013 thanks, it is done now

@Rastaban Rastaban merged commit a0415b3 into microsoft:master Apr 2, 2019
@kiwixz kiwixz deleted the pr/slim_webp branch April 2, 2019 21:26
@theoractice
Copy link

@kiwixz @Rastaban The freeimage library fails to build after this update. Seems that webp/mux.h is missing.
Any ideas?

@cenit
Copy link
Contributor

cenit commented Apr 3, 2019

#5886 (comment)

I cannot fully remember the details. But again, I tried saying “please check, together with @vicroms we were not crazy in that PR one month ago...”

@kiwixz
Copy link
Contributor Author

kiwixz commented Apr 3, 2019

@theoractice It looks like libwebp's CMakeLists.txt does not install this header when not building gif2webp/img2webp (and consequently libwebpmux), see https://github.com/webmproject/libwebp/blob/1.0.2/CMakeLists.txt#L396.

If that's sufficient to fix subsequent problems, it would probably be better to just force every headers to be installed, imo.

@LarryIII
Copy link
Contributor

LarryIII commented Apr 8, 2019

@theoractice freeimage was fixed in #5969

@theoractice
Copy link

theoractice commented Apr 12, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants