Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libpq] fix error at link time on linux #6016

Merged
merged 2 commits into from
Apr 12, 2019

Conversation

edmBernard
Copy link
Contributor

A fix for this issue #5884
It is observed when we try to link libpq with executable on linux.

@edmBernard
Copy link
Contributor Author

@Izowiuz I will wait for your review.

@edmBernard edmBernard changed the title [libpq] fix error at link time on linux WIP [libpq] fix error at link time on linux Apr 9, 2019
@Rastaban Rastaban added the wip label Apr 9, 2019
@Rastaban
Copy link
Contributor

Rastaban commented Apr 9, 2019

Could you also bump the version in the CONTROL file?

@NancyLi1013
Copy link
Contributor

Hi @edmBernard, I see some failures from the current CI system.

x64-linux master test notes
qt5-networkauth Pass Fail Regression
qt5-gamepad Pass Fail Regression
qt5-svg Pass Fail Regression
qt5-connectivity Pass Fail Regression
qt5-xmlpatterns Pass Fail Regression
qt5-charts Pass Fail Regression

@edmBernard
Copy link
Contributor Author

edmBernard commented Apr 12, 2019

@NancyLi1013 It's really strange test seem to work before my last commit that was only a version number. I rebase first to be sure. I will check after. Does qt5-base fail to build ?

@grdowns grdowns self-assigned this Apr 12, 2019
@grdowns
Copy link
Contributor

grdowns commented Apr 12, 2019

Thanks for the PR, @edmBernard!

@grdowns grdowns changed the title WIP [libpq] fix error at link time on linux [libpq] fix error at link time on linux Apr 12, 2019
@grdowns grdowns removed the wip label Apr 12, 2019
@grdowns grdowns merged commit 0bfa4c8 into microsoft:master Apr 12, 2019
@edmBernard edmBernard deleted the dev/fix_libpq_on_linux branch April 14, 2019 12:00
azure-sdk added a commit to azure-sdk/vcpkg that referenced this pull request Oct 3, 2024
## 1.14.0 (2024-10-03)

### Features Added

- Added a new constructor for `Azure::Core::Context` that takes an `Azure::DateTime` deadline. This enables creating a new context directly with a deadline.
- Request logs to now include the `accept-range`, `content-range`, `range`, `WWW-Authenticate`, `x-ms-date`, `x-ms-error-code`, `x-ms-range`, and `x-ms-version` headers.
- Added default constructor, `Parse()`, and equality comparison operators to `Azure::Core::Uuid`.
- Added an `Azure::Core::ResourceIdentifier` type.

### Breaking Changes

- Deprecated the `Azure::Core::Context::ApplicationContext` object.
  - If customer code is using `Azure::Core::Context::ApplicationContext`, the customer should instead create their own root context object which is used
  wherever the customer would have previously used `Azure::Core::Context::ApplicationContext`, i.e. `Azure::Core::Context(deadline)` instead of `Azure::Core::Context::ApplicationContext.WithDeadline(deadline)`.

### Bugs Fixed

- Throw `std::invalid_argument` if the value of `TimeFractionFormat` enum passed in to `DateTime::ToString()` is invalid.
- `Azure::Core::Uuid::ToString()` is now `const`.
- Make the HTTP transport behavior consistent between WinHTTP and libcurl by disabling automatically following redirects on Windows.
- Added basic input validation to `Azure::Core::ResourceIdentifier` to ensure the prefix match what is expected.

### Other Changes

- [[microsoft#5851]](Azure/azure-sdk-for-cpp#5851) Remove unneeded `<regex>` includes. (A community contribution, courtesy of _[rschu1ze](https://github.com/rschu1ze)_)
- [[microsoft#6014]](Azure/azure-sdk-for-cpp#6014), [[microsoft#6016]](Azure/azure-sdk-for-cpp#6016) Fixes for Doxygen generation. (A community contribution, courtesy of _[chewi](https://github.com/chewi)_)

### Acknowledgments

Thank you to our developer community members who helped to make Azure Core better with their contributions to this release:

- Robert Schulze _([GitHub](https://github.com/rschu1ze))_
- James Le Cuirot _([GitHub](https://github.com/chewi))_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants