[boost] Update to 1.70.0 #6141

ras0219-msft · 2019-04-19T01:17:40Z

No description provided.

BurningEnlightenment · 2019-04-19T11:14:52Z

@ras0219 this PRr doesn't update the boost-build port. Is this intentional?
Compiled boost libraries (like boost-exception) won't compile under VS2019 without the boost build update. This is due to the inability of boost-build 1.69.0 to use/discover VS2019.

ras0219-msft · 2019-04-19T23:51:10Z

Thanks for the comment! This was not intentional -- I need to update boost-build as well.

…e boost 1.70

[fizz][folly] Update and fix for boost 1.70 [libsodium] Use CMake buildsystem replacement to enable non-Windows

ras0219-msft · 2019-04-24T18:43:36Z

@bitsrules We have a script which generates 99% of the changes located at ports\boost-vcpkg-helpers\generate-ports.ps1.

The status as of b1b9922 was

x64-windows	master	test	notes
wangle	Pass	Fail	Regression
boost-outcome		Pass	New Port
boost-histogram		Pass	New Port

x64-windows-static	master	test	notes
wangle	Pass	Fail	Regression
boost-outcome		Pass	New Port
boost-histogram		Pass	New Port
pcl	Pass	Fail	Regression

x86-windows	master	test	notes
boost-outcome		Pass	New Port
boost-histogram		Pass	New Port
pcl	Pass	Fail	Regression

I believe I've fixed the wangle issue in 09477ff, so the only thing left is pcl.

nickoe · 2019-05-05T11:44:03Z

@ras0219-msft Hi, are you able to rebase this?

philjdf · 2019-05-09T09:35:14Z

Hi @ras0219, your Arrow port change removes the following args from vcpkg_configure_cmake

    -DBOOST_ROOT=${CURRENT_INSTALLED_DIR}
    -DBUILD_STATIC=${ARROW_BUILD_STATIC}
    -DBUILD_SHARED=${ARROW_BUILD_SHARED}
    -DPARQUET_ARROW_LINKAGE=${PARQUET_ARROW_LINKAGE}
    -DARROW_BOOST_USE_SHARED=${BOOST_USE_SHARED}
    -DARROW_USE_STATIC_CRT=${USE_STATIC_CRT}

Is this because they were superfluous?

ras0219-msft · 2019-05-09T20:01:08Z

Yes, after reviewing the CMakeLists.txt for arrow I determined that they were all superfluous.

fwosar · 2019-05-15T18:32:45Z

Is there anything that can be done to help move this along? The details of what fails don't seem to be public. The fact that there is no way to use the arguably most important C++ library with Visual Studio 2019 and vcpkg is kind of baffling.

Sixshaman · 2019-05-15T23:01:45Z

Is there anything that can be done to help move this along? The details of what fails don't seem to be public. The fact that there is no way to use the arguably most important C++ library with Visual Studio 2019 and vcpkg is kind of baffling.

I second this, can we do anything to help?

ras0219-msft · 2019-05-17T01:34:23Z

Thanks for the offers!

@fwosar Can you confirm that this resolves all your issues using boost with 2019?

star-e · 2019-05-17T03:23:03Z

When building boost 1.70 with vs2019, generated binaries are renamed to vc141-1_69
I have installed both vs2017 and vs2019. vs2019 has vc141 tool chain.

OlafvdSpek · 2019-05-17T08:03:01Z

MSVC 16.1.0 Preview 3.0:

notice: found boost-build.jam at C:/vc/b/vcpkg/installed/x86-windows/tools/boost-build/boost-build.jam
notice: loading Boost.Build from C:/vc/b/vcpkg/installed/x86-windows/tools/boost-build/src/kernel
notice: Site configuration files will be ignored due to the
notice: --ignore-site-config command-line option.
notice: Loading explicitly specified user configuration file:
    C:\vc\b\vcpkg\buildtrees\boost-regex\x86-windows-rel\user-config.jam
notice: Searching 'C:\vc\b\vcpkg\buildtrees\boost-regex\x86-windows-rel' for user-config configuration file 'user-config.jam'.
notice: Loading user-config configuration file 'user-config.jam' from 'C:/vc/b/vcpkg/buildtrees/boost-regex/x86-windows-rel'.

warning: Did not find command for MSVC toolset. If you have Visual Studio 2017 installed you will need to specify the full path to the command, set VS150COMNTOOLS for your installation, or build from the 'Visual Studio Command Prompt for VS 2017'.

notice: will use 'cl.exe' for msvc, condition <toolset>msvc
notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>/<address-model>', setup: 'C:/vc/b/vcpkg/installed/x86-windows/share/boost-build/nothing.bat' notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>/<address-model>', setup: 'x86'
notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>/<address-model>32', setup: 'C:/vc/b/vcpkg/installed/x86-windows/share/boost-build/nothing.bat' notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>/<address-model>32', setup: 'x86'
notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>x86/<address-model>', setup: 'C:/vc/b/vcpkg/installed/x86-windows/share/boost-build/nothing.bat' notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>x86/<address-model>', setup: 'x86'
notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>x86/<address-model>32', setup: 'C:/vc/b/vcpkg/installed/x86-windows/share/boost-build/nothing.bat' notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>x86/<address-model>32', setup: 'x86'
notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>/<address-model>64', setup: 'C:/vc/b/vcpkg/installed/x86-windows/share/boost-build/nothing.bat' notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>/<address-model>64', setup: 'amd64'
notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>x86/<address-model>64', setup: 'C:/vc/b/vcpkg/installed/x86-windows/share/boost-build/nothing.bat' notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>x86/<address-model>64', setup: 'amd64'
notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>ia64/<address-model>', setup: 'C:/vc/b/vcpkg/installed/x86-windows/share/boost-build/nothing.bat' notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>ia64/<address-model>', setup: 'x86_ia64'
notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>ia64/<address-model>64', setup: 'C:/vc/b/vcpkg/installed/x86-windows/share/boost-build/nothing.bat' notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>ia64/<address-model>64', setup: 'x86_ia64'
notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>arm/<address-model>', setup: 'C:/vc/b/vcpkg/installed/x86-windows/share/boost-build/nothing.bat' notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>arm/<address-model>', setup: 'x86_arm'
notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>arm/<address-model>32', setup: 'C:/vc/b/vcpkg/installed/x86-windows/share/boost-build/nothing.bat' notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>arm/<address-model>32', setup: 'x86_arm'
notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>arm/<address-model>', setup: 'C:/vc/b/vcpkg/installed/x86-windows/share/boost-build/nothing.bat' notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>arm/<address-model>', setup: 'x86_arm64'
notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>arm/<address-model>64', setup: 'C:/vc/b/vcpkg/installed/x86-windows/share/boost-build/nothing.bat' notice: [msvc-cfg] condition: '<toolset>msvc/<architecture>arm/<address-model>64', setup: 'x86_arm64'
notice: [cmdline-cfg] toolset msvc-14.1 not previously configured; attempting to auto-configure now
error: msvc initialization: parameter 'version' inconsistent
error: no value was specified in earlier initialization
error: an explicit value is specified now

chrullrich · 2019-05-17T08:27:48Z

When building boost 1.70 with vs2019, generated binaries are renamed to vc141-1_69
I have installed both vs2017 and vs2019. vs2019 has vc141 tool chain.

Same here. Somewhere during the build, something installs share/boost-build/Jamroot.jam; this file still mentions 1.69 at the top, and changing that to 1.70 appears to fix the library names.

The vcpkg port of websocketpp has been pointing to the upstream commit 1c699ce of a PR, in order to fix build issues of websocketpp 0.8.1 with boost 1.70 (microsoft#6141). This fix has been merged upstream in the meantime and is part of the release 0.8.2 now. - Update to WebSocket++/0.8.2 release - Remove deprecated include(vcpkg_common_functions) - Use ${PORT} instead of websocketpp

The vcpkg port of websocketpp has been pointing to the upstream commit 1c699ce of a PR, in order to fix build issues of websocketpp 0.8.1 with boost 1.70 (#6141). This fix has been merged upstream in the meantime and is part of the release 0.8.2 now. - Update to WebSocket++/0.8.2 release - Remove deprecated include(vcpkg_common_functions) - Use ${PORT} instead of websocketpp

[boost] Update to 1.70.0

e34e0d2

ras0219-msft added the info:internal This PR or Issue was filed by the vcpkg team. label Apr 19, 2019

ras0219-msft added 2 commits April 19, 2019 16:59

[boost-build] Update to 1.70.0

d646930

[folly][freeopcua][libtorrent][websocketpp] Upgrades/patches to handl…

4412ca0

…e boost 1.70

ras0219-msft mentioned this pull request Apr 22, 2019

boost::apply_visitor() no longer allows visitors to accept lvalues (regression) boostorg/variant#69

Closed

[boost-variant] Revert to 1.69 due to regression

b1b9922

[fizz][folly] Update and fix for boost 1.70 [libsodium] Use CMake buildsystem replacement to enable non-Windows

LilyWangL mentioned this pull request Apr 22, 2019

Update boost to 1.70 #6091

Closed

[wangle] Update. [folly] Avoid linking debug libs in release.

09477ff

ncihnegn mentioned this pull request Apr 24, 2019

Fix boost-build for VS2019 (vc142) #5976

Closed

TheScarfix mentioned this pull request Apr 29, 2019

boost [1.69] error MSVC [2019] #6255

Closed

pratikpc mentioned this pull request May 2, 2019

[boost-regex]Error build on visual studio 2019 #6021

Closed

Rastaban self-assigned this May 6, 2019

ras0219-msft added 2 commits May 6, 2019 17:10

Merge remote-tracking branch 'origin/master' into dev/roschuma/boost

ad31db7

[pcl] Fix compatibility with boost 1.70

79d1c3f

s-martin mentioned this pull request May 8, 2019

Error: Building package boost-exception:x64-windows failed with: BUILD_FAILED #6330

Closed

Merge remote-tracking branch 'origin/master' into HEAD

66f34d6

PhoebeHui mentioned this pull request May 8, 2019

Errors building shared library due to Boost Log and PIC #6148

Closed

ras0219-msft added 2 commits May 8, 2019 17:41

[fizz] Handle merge regression

cd994fc

[arrow] Modernize and fix cmake targets

c9ce15f

JackBoosY mentioned this pull request May 15, 2019

Installing boost with VCPKG_PLATFORM_TOOLSET v141 #5376

Closed

ras0219-msft added 2 commits May 15, 2019 16:51

[boost-type-traits] Update patches for arm64-windows

a78c0ab

[boost-locale] Add boost-system and boost-thread as arm64 dependencies

6fdcac8

[ompl] Add missing boost-timer dependency

8e4cfca

ras0219-msft merged commit 9d473a6 into microsoft:master May 17, 2019

ras0219-msft deleted the dev/roschuma/boost branch May 17, 2019 01:33

This was referenced May 17, 2019

Installing boost-system:x64-windows with VS2019 installed failed #6477

Closed

Error: Building package boost-container:x64-windows failed with: BUILD_FAILED #6289

Closed

Error: Building package boost-exception:x86-windows failed with: BUILD_FAILED #6437

Closed

chrullrich mentioned this pull request May 17, 2019

Boost 1.70 wrongly renames libraries to 1.69 #6493

Closed

JackBoosY mentioned this pull request May 18, 2019

Boost-1.70: Boost.Variant builds version 1.69 #6514

Closed

NancyLi1013 mentioned this pull request Jul 5, 2019

ICU not detected in boost-locale #3537

Closed

c72578 mentioned this pull request Apr 23, 2020

[websocketpp] Update to 0.8.2 #10969

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[boost] Update to 1.70.0 #6141

[boost] Update to 1.70.0 #6141

ras0219-msft commented Apr 19, 2019

BurningEnlightenment commented Apr 19, 2019

ras0219-msft commented Apr 19, 2019

ras0219-msft commented Apr 24, 2019

nickoe commented May 5, 2019 •

edited

Loading

philjdf commented May 9, 2019

ras0219-msft commented May 9, 2019

fwosar commented May 15, 2019 •

edited

Loading

Sixshaman commented May 15, 2019 •

edited

Loading

ras0219-msft commented May 17, 2019

star-e commented May 17, 2019

OlafvdSpek commented May 17, 2019 •

edited

Loading

chrullrich commented May 17, 2019 •

edited

Loading

[boost] Update to 1.70.0 #6141

[boost] Update to 1.70.0 #6141

Conversation

ras0219-msft commented Apr 19, 2019

BurningEnlightenment commented Apr 19, 2019

ras0219-msft commented Apr 19, 2019

ras0219-msft commented Apr 24, 2019

nickoe commented May 5, 2019 • edited Loading

philjdf commented May 9, 2019

ras0219-msft commented May 9, 2019

fwosar commented May 15, 2019 • edited Loading

Sixshaman commented May 15, 2019 • edited Loading

ras0219-msft commented May 17, 2019

star-e commented May 17, 2019

OlafvdSpek commented May 17, 2019 • edited Loading

chrullrich commented May 17, 2019 • edited Loading

nickoe commented May 5, 2019 •

edited

Loading

fwosar commented May 15, 2019 •

edited

Loading

Sixshaman commented May 15, 2019 •

edited

Loading

OlafvdSpek commented May 17, 2019 •

edited

Loading

chrullrich commented May 17, 2019 •

edited

Loading