Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[paho-mqttpp3] Add New Port: Paho MQTT C++ library #7033

Merged
merged 8 commits into from
Jul 15, 2019

Conversation

thedevilfish
Copy link
Contributor

This is a pull request to support Eclipse's Paho MQTT C++ library. More more information about the library please see: Eclipse Paho

@thedevilfish thedevilfish changed the title [Newport] Paho MQTT C++ library: pahomqttpp3 [paho-mqttpp3] New Port: Paho MQTT C++ library Jun 25, 2019
@thedevilfish thedevilfish changed the title [paho-mqttpp3] New Port: Paho MQTT C++ library [paho-mqttpp3] Add New Port: Paho MQTT C++ library Jun 25, 2019
ports/paho-mqttpp3/CONTROL Outdated Show resolved Hide resolved
ports/paho-mqttpp3/portfile.cmake Outdated Show resolved Hide resolved
ports/paho-mqttpp3/portfile.cmake Outdated Show resolved Hide resolved
ports/paho-mqttpp3/portfile.cmake Outdated Show resolved Hide resolved
ports/paho-mqttpp3/portfile.cmake Outdated Show resolved Hide resolved
ports/paho-mqttpp3/portfile.cmake Outdated Show resolved Hide resolved
ports/paho-mqttpp3/portfile.cmake Show resolved Hide resolved
Copy link
Contributor Author

@thedevilfish thedevilfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed all code review comments.

@thedevilfish
Copy link
Contributor Author

thedevilfish commented Jun 28, 2019

@ras0219 I've updated the pull request addressing your comments. Please can you review my changes? Thanks in advance!

Copy link
Contributor Author

@thedevilfish thedevilfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed code review comments.

@vicroms
Copy link
Member

vicroms commented Jul 15, 2019

@thedevilfish
Thanks for the PR !

@vicroms vicroms merged commit 40200c8 into microsoft:master Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants