[freetype]Re-fixed the issue of exporting symbols when building dynamic library. #7141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rastaban
reviewed
Jul 8, 2019
| 0002-Add-CONFIG_INSTALL_PATH-option.patch | ||
| 0003-Fix-UWP.patch | ||
| ) | ||
| set(ENABLE_DLL_EXPORT OFF) |
There was a problem hiding this comment.
I have seen this solved in other ports by deleting the source directory if it exists before extracting. I like your solution better, Thanks!.
Rastaban
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have built a dynamic library, since there is already a source cache, the patch will not be applied.
It is unreasonable to use the condition to determine whether to apply the patch.
Related: #5853.