Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[irrlicht] use unicode path on windows #7354

Merged
merged 3 commits into from
Jul 22, 2019
Merged

[irrlicht] use unicode path on windows #7354

merged 3 commits into from
Jul 22, 2019

Conversation

DailyShana
Copy link
Contributor

use unicode path on windows
also patch /include/Keycodes.h to utf-8 encoding

@DailyShana DailyShana marked this pull request as ready for review July 21, 2019 15:38
these macros should be defined when using system libraries
@Rastaban
Copy link
Contributor

The linux failure is due to an unrelated flaky port and can be ignored, so this is clean. Thanks for the update!

@Rastaban Rastaban merged commit 22be764 into microsoft:master Jul 22, 2019
@DailyShana DailyShana deleted the irrlicht branch July 22, 2019 06:19
adrido pushed a commit to adrido/vcpkg that referenced this pull request Aug 16, 2019
cbezault added a commit that referenced this pull request Aug 16, 2019
Revert "[irrlicht] use unicode path on windows (#7354)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants