Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve logic expression evaluation #7508

Merged
merged 6 commits into from
Aug 3, 2019

Conversation

Rastaban
Copy link
Contributor

@Rastaban Rastaban commented Aug 1, 2019

Improve the logic expression evaluation currently used when filtering dependencies.

Biggest improvements:
Allow '|' operator
Support nested '()'
Allow whitespace
Useful error message for malformed expressions

Also changed names of types to RawParagraph if that is what the original author was using.

Improve the logic expression evaluation currently used when filtering
dependencies.

Biggest improvements:
  Allow '|' operator
  Support nested '()'
  Allow whitespace
  Usefull error message for malformed expressions

Also changed names of types to RawParagraph when that is what the original author was using.
@Rastaban Rastaban added the info:internal This PR or Issue was filed by the vcpkg team. label Aug 1, 2019
@Rastaban Rastaban self-assigned this Aug 1, 2019
@Rastaban
Copy link
Contributor Author

Rastaban commented Aug 1, 2019

Forcing a full rebuild test on https://dev.azure.com/vcpkg/public/_build/results?buildId=7536

@Rastaban Rastaban merged commit 22e0b9f into microsoft:master Aug 3, 2019
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
* better logic expression evaluation

Improve the logic expression evaluation currently used when filtering
dependencies.

Biggest improvements:
+  Allow '|' operator
+  Support nested '()'
+  Allow whitespace
+  Useful error message for malformed expressions

Also changed names of types to RawParagraph when that is what the original author was using.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant