[netcdf-c] correctly fix hdf5 linkage #7578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbezault
reviewed
Aug 7, 2019
|
|
||
| # Remember to package this file for CMake builds. | ||
| ADD_EXTRA_DIST(${libnchdf5_SOURCES} CMakeLists.txt) | ||
| + | ||
| +if(BUILD_SHARED_LIBS) | ||
| +target_link_libraries(netcdfhdf5 PRIVATE hdf5::hdf5-shared hdf5::hdf5-static hdf5::hdf5_hl-shared hdf5::hdf5_hl-static) | ||
| +if(HDF5_BUILD_SHARED_LIBS) |
There was a problem hiding this comment.
What is the context for not using BUILD_SHARED_LIBS?
There was a problem hiding this comment.
users of vcpkg are free to mix and match dynamic/static libraries as they see fit in a custom triplet. So users are free to mix a static/dynamic build of hdf5 with a dynamic/static build of netcdf. As such the conditional must check wether or not hdf5 has been build as a static or dynamic library. The variable BUILD_SHARED_LIBS just means that the currently build package is build as a dynamic library and not how its dependent libraries have been build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7577