Fix building feature opencv halide #7581
Conversation
ports/opencv/CONTROL
Outdated
| @@ -82,6 +82,10 @@ Feature: eigen | |||
| Build-Depends: eigen3 | |||
| Description: Eigen support for opencv | |||
|
|
|||
| Feature: halide | |||
| Build-Depends: halide, opencv[dnn] | |||
There was a problem hiding this comment.
This will also pull in all the default opencv features, is that the intent?
If all you need is really just opencv[dnn] you should write opencv[core], opencv[dnn].
There was a problem hiding this comment.
No, the default features are not required.
But changing line 86 to Build-Depends: halide, opencv[core], opencv[dnn] and running vcpkg install opencv[halide]:x64-windows printed:
The following packages will be built and installed:
- eigen3[core]:x64-windows
- halide[core]:x64-windows
- libjpeg-turbo[core]:x64-windows
- liblzma[core]:x64-windows
- libpng[core]:x64-windows
opencv[core,dnn,eigen,flann,halide,jpeg,opengl,png,tiff]:x64-windows - opengl[core]:x64-windows
- protobuf[core]:x64-windows
- tiff[core]:x64-windows
- zlib[core]:x64-windows
The result is the same without changing line 86.
What is the effect of the suggested change?
There was a problem hiding this comment.
You need to write vcpkg install opencv[core,halide] on the command line to see the difference in behavior.
There was a problem hiding this comment.
Even with Build-Depends: halide, opencv[dnn] and writing vcpkg install opencv[core,halide] it will only build opencv[core,dnn,halide] - no differences compared to Build-Depends: halide, opencv[core], opencv[dnn].
There was a problem hiding this comment.
That is a bug, caused by the fact that we don't track the set of requested features that are the result of the user writing them into the command-line and the result of them existing in a Build-Depends list separately.
We should still write out opencv[core], opencv[dnn].
|
@NiHoel, all the work on this PR needs to be migrated to the opencv4 port. I'll do it if I have a second but it would be much appreciated if you could do it. |
ports/opencv/CONTROL
Outdated
| Default-Features: dnn, jpeg, opengl, png, tiff, webp | ||
|
|
||
| Feature: nonfree | ||
| Build-Depends: opencv4[nonfree] |
There was a problem hiding this comment.
All of these features should Build-Depends on opencv4[core], opencv4[<feature-name>].
There was a problem hiding this comment.
I got a bit lost, why is that needed?
Requesting opencv4[core] from the meta-package will install all the default features anyway.
(All the following examples are after applying the requested change: Build-Depends: opencv4[core], opencv4[<feature-name>])
Meta-package with default features
./vcpkg install opencv
The following packages will be built and installed:
opencv[core,dnn,jpeg,opengl,png,tiff,webp]:x64-windows
* opencv4[core,dnn,jpeg,opengl,png,tiff,webp]:x64-windows
Meta-package without default features (core).
Requesting core from the meta-package disables the default-features on itself, however it cannot disable the default-features of the dependent opencv4.
PS D:\src\viromer\vcpkg> ./vcpkg install opencv[core]
The following packages will be built and installed:
opencv[core]:x64-windows
* opencv4[core,dnn,jpeg,opengl,png,tiff,webp]:x64-windows
Meta-package with extra feature
No difference between [feature] and [core,feature].
./vcpkg install opencv[halide]
The following packages will be built and installed:
opencv[core,dnn,halide,jpeg,opengl,png,tiff,webp]:x64-windows
* opencv4[core,dnn,halide,jpeg,opengl,png,tiff,webp]:x64-windows
./vcpkg install opencv[core,halide]
The following packages will be built and installed:
opencv[core,halide]:x64-windows
* opencv4[core,dnn,halide,jpeg,opengl,png,tiff,webp]:x64-windows
No meta-package
If you really want opencv4[core], then you have to skip the meta-package completely.
./vcpkg install opencv4
The following packages will be built and installed:
opencv4[core,dnn,jpeg,opengl,png,tiff,webp]:x64-windows
./vcpkg install opencv4[core]
The following packages will be built and installed:
opencv4[core]:x64-windows
There was a problem hiding this comment.
Yes it's true that requesting opencv4[core] from the build depends will give you the default features but that is a bug. The intention is that the package spec should mean the same thing everywhere. In this case there's a discrepancy in the behavior of the special feature core.
Note this is only true of dependencies on other ports. If you have a feature that depends on another feature within the port it mostly works. See #7472
No description provided.