Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenCV 3] update to v3.4.7 #7658

Merged
merged 13 commits into from
Aug 23, 2019
Merged

[OpenCV 3] update to v3.4.7 #7658

merged 13 commits into from
Aug 23, 2019

Conversation

cenit
Copy link
Contributor

@cenit cenit commented Aug 12, 2019

align the portfile to the opencv4 one to ease mainteinance

@vicroms
Copy link
Member

vicroms commented Aug 13, 2019

We should have separate PRs for both versions, so that improvements on OpenCV 4 don't get delayed because of OpenCV3.

@cenit
Copy link
Contributor Author

cenit commented Aug 13, 2019

as of now, any touch on opencv4 is not an improvement to the port itself, it is just to ease alignment.

I am trying to uniform ports so that mainteinance can be very easy also on "older" opencv3

@cenit cenit marked this pull request as ready for review August 13, 2019 14:19
@cenit
Copy link
Contributor Author

cenit commented Aug 13, 2019

Base work should be ready.
@vicroms if you have anyone interested in opencv3, please let them try this update, then it might be ready for merging, having already all the improvements that went into opencv4.
The huge work went into the dependencies, now we are very quick in adopting new releases and if opencv3 can also receive some love then why not :)
(shall I reopen the opencv2 port PR? 🤣 )

@cenit
Copy link
Contributor Author

cenit commented Aug 14, 2019

I also tried to minimize raw diffs between opencv4 and opencv3 ports. They should look as similar as possible. Any difference should be due to something necessary, otherwise I tried to remove all of them. Naming inside the control file, names of the patches themselves, ...

ports/opencv3/portfile.cmake Outdated Show resolved Hide resolved
ports/opencv3/portfile.cmake Outdated Show resolved Hide resolved
@vicroms vicroms dismissed their stale review August 15, 2019 22:28

Fixed vcpkg_check_features() call

@vicroms
Copy link
Member

vicroms commented Aug 22, 2019

This LGTM, @cenit are there any other pending changes?

@vicroms
Copy link
Member

vicroms commented Aug 22, 2019

(shall I reopen the opencv2 port PR? 🤣 )

I know you're joking (right? 😅), but I got word from a team that might actually want to use OpenCV 2.4, (luckily they're aware of --overlay-ports) 😟

@cenit
Copy link
Contributor Author

cenit commented Aug 23, 2019

Nothing pending for now. You can merge

I was joking, yes, but the PR for 2.4 is easy to be reopened... #7849

@vicroms vicroms merged commit d85a40d into microsoft:master Aug 23, 2019
@cenit
Copy link
Contributor Author

cenit commented Aug 24, 2019

there was a bug (typo) inside your last commit (FEATURE OPPTIONS with double P) 8bd3aab, which unfortunately i didn't even test so I didn't notice.
The fix is inside #7536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants