-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function vcpkg_configure_make/vcpkg_build_make/vcpkg_install_make/vcpkg_build_nmake/vcpkg_install_nmake #8267
Conversation
Add an option to use jom instead of nmake? (I should not be the person to write this since I always have problems with jom on my main pc but whatever....) |
@Neumann-A I considered jom, but we already have |
looking ahead, you can see an example of the assembly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
example TCL
vcpkg_download_distfile(ARCHIVE
URLS "https://prdownloads.sourceforge.net/tcl/tcl8.6.9-src.tar.gz"
FILENAME "tcl8.6.9-src.tar.gz"
SHA512 707fc0fb4f45c85e8f21692e5035d727cde27d87a2e1cd2e748ad373ebd3517aeca25ecaef3382a2f0e0a1feff96ce94a62b87abcf085e1a0afe2a23ef460112
)
vcpkg_extract_source_archive_ex(
OUT_SOURCE_PATH SOURCE_PATH
ARCHIVE ${ARCHIVE}
)
if(VCPKG_TARGET_ARCHITECTURE MATCHES "x64")
set(MACHINE_STR AMD64)
else()
set(MACHINE_STR IX86)
endif()
vcpkg_configure_make(
SOURCE_PATH ${SOURCE_PATH}
GENERATOR "nmake"
PROJECT_SUBPATH "/win"
PROJECT_PATH "makefile.vc"
OPTIONS
MACHINE=${MACHINE_STR}
OPTIONS_DEBUG
OPTS=symbols #symbols - debug version
POSTRUN_SHELL_RELEASE
INSTALLDIR=${CURRENT_PACKAGES_DIR} install
POSTRUN_SHELL_DEBUG
OPTS=symbols INSTALLDIR=${CURRENT_PACKAGES_DIR}/debug install
)
it seems everything works, compiles and installs)
with my edits
#vcpkg_install_make() # <<-- the script does not work #NMake
I don't quite understand the logic of NMake in vcpkg_configure_make when there is vcpkg_build_make
can NMake is to move fully in vcpkg_build_make ?
|
I suddenly realized that mixing |
|
@voskrese There are fewer ports using |
Finally, all the work is done (except for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything especially objectionable besides the fact we're not running make in parallel. Waiting on @vicroms more thorough review.
I just merged a TCL port, I guess I should have preferred this one... |
May I ask you what’s the meaning of
Is yasm supporting makefiles now in a more compatible windows way than nmake? I don’t know. I am wondering because that would be great news?!? |
@cbezault either close or merge and so on with the rest, many edits are simply outdated
|
@voskrese, I've moved on from this project in an official capacity. I'm just finishing up one more feature which is going to be useful for the ci. I'm also going to be in charge of the macos infrastructure for the foreseeable future. I'm just responding to/working on PRs I'm interested in outside of work. @dan-shaw, @grdowns and @vicroms can still help you. On another note jack is on vacation until next week and I think we want to talk to him about something before merging this. |
Well, I think this PR is ready. |
For Windows:
support nmake to handle makefilewill support this in the future.For UNIX:
Progress:
test in windows(nmake makefile)will support this in the future.