Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[glui] Add new port #9155

Merged
merged 6 commits into from
Jan 16, 2020
Merged

[glui] Add new port #9155

merged 6 commits into from
Jan 16, 2020

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented Nov 30, 2019 •
edited
Loading

@myd7349 myd7349 marked this pull request as ready for review November 30, 2019 09:30
@grdowns grdowns self-assigned this Dec 2, 2019
NancyLi1013
NancyLi1013 suggested changes Dec 12, 2019
View reviewed changes
ports/glui/portfile.cmake Outdated Show resolved Hide resolved
ports/glui/portfile.cmake Outdated Show resolved Hide resolved
ports/glui/portfile.cmake Outdated Show resolved Hide resolved
@NancyLi1013
Copy link
Contributor

@myd7349 thanks for this PR.
What does this PR fix? If there is no issue open for the PR, please open an issue so others may replicate this problem.

@dan-shaw
Copy link
Contributor

@NancyLi1013 This is a new port.

@NancyLi1013
Copy link
Contributor

/azp run

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Dec 17, 2019
@dan-shaw
Copy link
Contributor

dan-shaw commented Jan 9, 2020

/azp run

@NancyLi1013 NancyLi1013 self-assigned this Jan 14, 2020
@NancyLi1013
Copy link
Contributor

/azp run

@vicroms vicroms merged commit b2f7823 into microsoft:master Jan 16, 2020
@vicroms
Copy link
Member

vicroms commented Jan 16, 2020

Thanks for the PR!

cenit
cenit reviewed Jan 16, 2020
View reviewed changes
ports/freeglut/portfile.cmake
FREEGLUT_STDH
"${FREEGLUT_STDH}"
)
endif()
Copy link
Contributor

@cenit cenit Jan 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to editing the sources in the buildtree folder and not the installed ones, after this PR has been merged if you install freeglut in a static triplet and then install freeglut in a dynamic triplet, without deleting the buildtree folder (which is not required nor even suggested to users) everything is damaged and the compiler crashes. @vicroms

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Nice catch! @cenit Thanks for pointing it out. I should have patched it carefully. I have created a PR #9725 for fixing this.

myd7349 added a commit to myd7349/vcpkg that referenced this pull request Jan 17, 2020
@myd7349
[freeglut] Patch header correctly
855be33 
This fixes bug introduced by microsoft#9155.
@myd7349 myd7349 mentioned this pull request Jan 17, 2020
Merged
@myd7349 myd7349 deleted the glui-init branch January 17, 2020 05:39
vicroms pushed a commit that referenced this pull request Jan 22, 2020
@myd7349 @vicroms
[freeglut] Patch header correctly (#9725)
6e99bd4 
This fixes bug introduced by #9155.
@JackBoosY JackBoosY mentioned this pull request Jan 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cenit cenit cenit left review comments

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

@vicroms vicroms vicroms approved these changes

Assignees

@grdowns grdowns

@NancyLi1013 NancyLi1013

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@myd7349 @NancyLi1013 @dan-shaw @vicroms @cenit @strega-nil @grdowns