Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openmvs] Update to 1.0.1 #9563

Merged
merged 4 commits into from
Jan 10, 2020
Merged

[openmvs] Update to 1.0.1 #9563

merged 4 commits into from
Jan 10, 2020

Conversation

cdcseacave
Copy link
Contributor

This change updates OpenMVS library to v1.0.1. I've tested it on Windows and works as expected, but on Ubuntu 18.04 it fails with an error that does not seem related to my library; can you pls help solve this?

FAILED: bin/InterfaceCOLMAP 
: && /usr/bin/c++  -fPIC   -W -Wall -Werror=address -Werror=sequence-point -Wformat -Werror=format-security -Winit-self -Wsign-promo -Wreorder -Wno-undef -Wno-switch -Wno-switch-enum -Wno-switch-default -Wno-comment -Wno-narrowing -Wno-attributes -Wno-enum-compare -Wno-misleading-indentation -Wno-missing-field-initializers -Wno-unused-parameter -Wno-delete-incomplete -Wno-int-in-bool-context -fdiagnostics-show-option -ftemplate-backtrace-limit=0 -Wno-long-long -pthread -fomit-frame-pointer -frounding-math -msse -msse2 -msse3 -mssse3 -msse4.1 -msse4.2 -ffunction-sections -fopenmp -g  -O0 -D_DEBUG  -rdynamic apps/InterfaceCOLMAP/CMakeFiles/InterfaceCOLMAP.dir/InterfaceCOLMAP.cpp.o  -o bin/InterfaceCOLMAP -L/home/dd/Pro/vcpkg/installed/x64-linux/debug/lib -Wl,-rpath,/home/dd/Pro/vcpkg/installed/x64-linux/debug/lib: lib/libMVS.a lib/libMath.a lib/libIO.a lib/libCommon.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libboost_iostreams.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libboost_program_options.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libboost_system.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libboost_serialization.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libboost_regex.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libopencv_dnnd.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libprotobufd.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libopencv_highguid.a -lgthread-2.0 -lglib-2.0 /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libopencv_mld.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libopencv_objdetectd.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libquircd.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libopencv_photod.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libopencv_stitchingd.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libopencv_videod.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libopencv_calib3dd.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libopencv_features2dd.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libopencv_flannd.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libopencv_videoiod.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libopencv_imgcodecsd.a /home/dd/Pro/vcpkg/installed/x64-linux/lib/libjpeg.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libwebpd.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libwebpdecoderd.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libwebpdemuxd.a /home/dd/Pro/vcpkg/installed/x64-linux/lib/libjpeg.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libwebpd.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libwebpdecoderd.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libwebpdemuxd.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libopencv_imgprocd.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libopencv_cored.a /home/dd/Pro/vcpkg/installed/x64-linux/lib/libz.a -ldl -lpthread -lrt /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libpng16d.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libjpeg.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libtiffd.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/liblzmad.a -lm /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libmpfr.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libgmp.a /home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libz.a && :
/home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libtiffd.a(tif_jpeg.c.o): In function `TIFFjpeg_create_compress':
/home/dd/Pro/vcpkg/buildtrees/tiff/src/4.0.10-229dd2f530/libtiff/tif_jpeg.c:289: undefined reference to `jpeg_CreateCompress'
/home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libtiffd.a(tif_jpeg.c.o): In function `TIFFjpeg_set_defaults':
/home/dd/Pro/vcpkg/buildtrees/tiff/src/4.0.10-229dd2f530/libtiff/tif_jpeg.c:309: undefined reference to `jpeg_set_defaults'
/home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libtiffd.a(tif_jpeg.c.o): In function `TIFFjpeg_set_colorspace':
/home/dd/Pro/vcpkg/buildtrees/tiff/src/4.0.10-229dd2f530/libtiff/tif_jpeg.c:315: undefined reference to `jpeg_set_colorspace'
/home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libtiffd.a(tif_jpeg.c.o): In function `TIFFjpeg_set_quality':
/home/dd/Pro/vcpkg/buildtrees/tiff/src/4.0.10-229dd2f530/libtiff/tif_jpeg.c:321: undefined reference to `jpeg_set_quality'
/home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libtiffd.a(tif_jpeg.c.o): In function `TIFFjpeg_suppress_tables':
/home/dd/Pro/vcpkg/buildtrees/tiff/src/4.0.10-229dd2f530/libtiff/tif_jpeg.c:328: undefined reference to `jpeg_suppress_tables'
/home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libtiffd.a(tif_jpeg.c.o): In function `TIFFjpeg_start_compress':
/home/dd/Pro/vcpkg/buildtrees/tiff/src/4.0.10-229dd2f530/libtiff/tif_jpeg.c:334: undefined reference to `jpeg_start_compress'
/home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libtiffd.a(tif_jpeg.c.o): In function `TIFFjpeg_write_scanlines':
/home/dd/Pro/vcpkg/buildtrees/tiff/src/4.0.10-229dd2f530/libtiff/tif_jpeg.c:341: undefined reference to `jpeg_write_scanlines'
/home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libtiffd.a(tif_jpeg.c.o): In function `TIFFjpeg_write_raw_data':
/home/dd/Pro/vcpkg/buildtrees/tiff/src/4.0.10-229dd2f530/libtiff/tif_jpeg.c:348: undefined reference to `jpeg_write_raw_data'
/home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libtiffd.a(tif_jpeg.c.o): In function `TIFFjpeg_finish_compress':
/home/dd/Pro/vcpkg/buildtrees/tiff/src/4.0.10-229dd2f530/libtiff/tif_jpeg.c:355: undefined reference to `jpeg_finish_compress'
/home/dd/Pro/vcpkg/installed/x64-linux/debug/lib/libtiffd.a(tif_jpeg.c.o): In function `TIFFjpeg_write_tables':
/home/dd/Pro/vcpkg/buildtrees/tiff/src/4.0.10-229dd2f530/libtiff/tif_jpeg.c:361: undefined reference to `jpeg_write_tables'
collect2: error: ld returned 1 exit status

@cdcseacave
Copy link
Contributor Author

the automatic check for linux is wrong, the build fails (as reported above), but the check still passes

@PhoebeHui
Copy link
Contributor

@cdcseacave, thanks for the PR!

openmvs failed on linux but doesn't fail on CI testing, that due to it also failed on baseline, so it's not a regressions. Additionally 'openmvs:x64-linux=fail 'added to ci.baseline.txt, when the failures on linux fixed, the 'openmvs:x64-linux=fail ' should be removed.

@PhoebeHui PhoebeHui changed the title [openmvs] update [openmvs] Update to 1.0.1 Jan 8, 2020
ports/openmvs/CONTROL Outdated Show resolved Hide resolved
@cdcseacave
Copy link
Contributor Author

@PhoebeHui can you pls help with the linux build?

@PhoebeHui
Copy link
Contributor

/azp run

@PhoebeHui
Copy link
Contributor

@cdcseacave, sure, I will try to fix linux build issue in separate PR.
BTW, it doesn't block to merge this PR.

@cdcseacave
Copy link
Contributor Author

@PhoebeHui That is fine with me, pls feel free to merge, thx

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jan 10, 2020
@dan-shaw dan-shaw merged commit 3b5c2ec into microsoft:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants