Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[farmhash] Add new port #9929

Merged
merged 2 commits into from
Feb 12, 2020
Merged

Conversation

kreuzerkrieg
Copy link
Contributor

Google FarmHash

  • Which triplets are supported/not supported?
    uwp and arm on windows are not supported
    Have you updated the CI baseline?
    yes

  • Does your PR follow the maintainer guide?

Yes

ports/farmhash/CONTROL Show resolved Hide resolved
ports/farmhash/portfile.cmake Outdated Show resolved Hide resolved
@NancyLi1013
Copy link
Contributor

Hi @kreuzerkrieg thanks for this PR.
The regressions on x86-windows, x64-windows, x64-windows triplets:

Can't load '/usr/lib/perl5/core_perl/auto/POSIX/POSIX.dll' for module POSIX: No such process at /usr/share/perl5/core_perl/XSLoader.pm line 93.
  at /usr/lib/perl5/core_perl/POSIX.pm line 24.
Compilation failed in require at /usr/share/autoconf/Autom4te/FileUtils.pm line 266.
BEGIN failed--compilation aborted at /usr/share/autoconf/Autom4te/FileUtils.pm line 266.
Compilation failed in require at /usr/bin/autoreconf line 42.
BEGIN failed--compilation aborted at /usr/bin/autoreconf line 42.

Could you please take a look and try to fix them?

@kreuzerkrieg
Copy link
Contributor Author

Hi @kreuzerkrieg thanks for this PR.
The regressions on x86-windows, x64-windows, x64-windows triplets:

Can't load '/usr/lib/perl5/core_perl/auto/POSIX/POSIX.dll' for module POSIX: No such process at /usr/share/perl5/core_perl/XSLoader.pm line 93.
  at /usr/lib/perl5/core_perl/POSIX.pm line 24.
Compilation failed in require at /usr/share/autoconf/Autom4te/FileUtils.pm line 266.
BEGIN failed--compilation aborted at /usr/share/autoconf/Autom4te/FileUtils.pm line 266.
Compilation failed in require at /usr/bin/autoreconf line 42.
BEGIN failed--compilation aborted at /usr/bin/autoreconf line 42.

Could you please take a look and try to fix them?

Dont have a win machine at hand right now, will check it later

@kreuzerkrieg kreuzerkrieg mentioned this pull request Feb 6, 2020
@kreuzerkrieg
Copy link
Contributor Author

Hi @kreuzerkrieg thanks for this PR.
The regressions on x86-windows, x64-windows, x64-windows triplets:
Can't load '/usr/lib/perl5/core_perl/auto/POSIX/POSIX.dll' for module POSIX: No such process at /usr/share/perl5/core_perl/XSLoader.pm line 93.
at /usr/lib/perl5/core_perl/POSIX.pm line 24.
Compilation failed in require at /usr/share/autoconf/Autom4te/FileUtils.pm line 266.
BEGIN failed--compilation aborted at /usr/share/autoconf/Autom4te/FileUtils.pm line 266.
Compilation failed in require at /usr/bin/autoreconf line 42.
BEGIN failed--compilation aborted at /usr/bin/autoreconf line 42.

Could you please take a look and try to fix them?

Ok, checked it. Well, I didnt get same messages but it clearly cant be compiled on Windows, at least I dont see it happening without intervention in the original autotools script
Meanwhile I've disabled builds for win/uwp for all architectures and all builds for arm

@ras0219-msft ras0219-msft merged commit 6abebce into microsoft:master Feb 12, 2020
@ras0219-msft
Copy link
Contributor

Thanks for the PR!

This is fine for now, however looking at the upstream sources it seems that the build process is actually very simple for the library -- just src/farmhash.cc and src/farmhash.h. A very nice improvement would be to add a CMake replacement buildsystem, which would enable compiling for more targets and easier tweaking of flags for users (such as passing -march).

KineticTheory pushed a commit to KineticTheory/vcpkg that referenced this pull request Feb 17, 2020
* FarmHash, a family of hash functions.

* WiP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants