-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[angle] Improve port #9965
[angle] Improve port #9965
Conversation
Neumann-A
commented
Feb 7, 2020
- update opengl-registry
- give opengl-registry headers priority
- allow static builds
- make cmake build more equivalent to native builds.
@Neumann-A, glad failed on windows all triplets on CI testing, does this expect? |
@PhoebeHui It seems to be a file encoding problem. After changing the encoding of the *.xml files from UTF-8 with BOM to only UTF-8 |
@Neumann-A Sorry for the delay. During the weekend, I will review your PRs: #9965, #9864, #9861, #9705 and more. |
ports/angle/CMakeLists.txt
Outdated
|
||
SET_TARGET_PROPERTIES(libANGLE PROPERTIES PREFIX "") | ||
SET_TARGET_PROPERTIES(libGLESv2 PROPERTIES PREFIX "") | ||
SET_TARGET_PROPERTIES(libEGL PROPERTIES PREFIX "") | ||
|
||
install(TARGETS libEGL libGLESv2 EXPORT ANGLEExport | ||
install(TARGETS libEGL libGLESv2 libANGLE angle_common angle_image_util angle_gpu_info_util angle_translator angle_preprocessor angle_renderer_opengl EXPORT ANGLEExport |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even when using x64-windows triplet which uses dynamic linkage, libANGLE.lib is put into installed\x64-windows\lib
and it's about 830 MiB in size. Together with installed\x64-windows\debug\lib\libANGLE.lib (880 MiB) this single line adds 1.67 GiB of unnecessary bloat. Please, install static libraries only when x64-windows-static is used.