Support System.ComponentModel.Composition (MEFv1) on nuget.org #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the System.ComponentModel.Composition NuGet package, the MEFv1 engine runs on netcoreapp2.0 and all the MEF attributes are available on .NETStandard2.0, so we don't need to define them any more. Instead, we revert to type forwarders and have a transitive package dependency on the official package.
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
=======================================
Coverage 85.86% 85.86%
=======================================
Files 67 67
Lines 5581 5581
Branches 865 865
=======================================
Hits 4792 4792
Misses 552 552
Partials 237 237
Continue to review full report at Codecov.
|
jepetty
approved these changes
Mar 16, 2018
|
Makes sense to me |
AArnott
pushed a commit
that referenced
this pull request
Jun 7, 2022
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.7.0 to 16.7.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v16.7.0...v16.7.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our new Microsoft.VisualStudio.Composition.NetFxAttributes package and VS MEF engine to support the MEFv1 attributes as defines for .NETStandard 2.0 now found on NuGet.org.
Closes #66