Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make interface IJsonRpcMessageWithId public #667

Closed
pandaGaume opened this issue May 25, 2021 · 0 comments · Fixed by #717
Closed

Make interface IJsonRpcMessageWithId public #667

pandaGaume opened this issue May 25, 2021 · 0 comments · Fixed by #717
Assignees
@AArnott
Labels
enhancement
Milestone
v2.9

Comments

@pandaGaume
Copy link

When manipulate JsonRpcMessage, especially into handler, it's will be easiest to cast the message as IJsonRpcMessageWithId.

if( mess is IJsonRpcMessageWithId messWithId)
{
   var id = messWithId.RequestId;
   ...
}

Regards
@AArnott AArnott added this to the v2.9 milestone Jun 9, 2021
AArnott added a commit to AArnott/vs-streamjsonrpc that referenced this issue Sep 20, 2021
@AArnott
Expose the IJsonRpcMessageWithId interface publicly
ffd472b 
Closes microsoft#667
@AArnott AArnott self-assigned this Sep 20, 2021
@AArnott AArnott mentioned this issue Sep 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
enhancement
Projects
None yet
Milestone
v2.9
Development

Successfully merging a pull request may close this issue.

Expose the IJsonRpcMessageWithId interface publicly AArnott/vs-streamjsonrpc
2 participants
@AArnott @pandaGaume