Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddLocalRpcTarget<T> should honor base interfaces when T is an interface #652

Merged
merged 4 commits into from
Apr 24, 2021
Merged

AddLocalRpcTarget<T> should honor base interfaces when T is an interface #652

merged 4 commits into from
Apr 24, 2021

Conversation

rruizGit
Copy link
Contributor

@rruizGit rruizGit commented Mar 29, 2021 •
edited by AArnott
Loading

The fix is to basically "collect" types to map differently if the exposedMembersOnType is an interface or a class.

Fixes #637: Usage mismatch between AddTarget and Attach when using interface inheritance.

@ghost
Copy link

ghost commented Mar 29, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

AArnott
AArnott approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I have a couple of touch-ups to make on this as well as adding a regression test. I'll merge this together and complete the PR soon.

@AArnott AArnott self-assigned this Apr 5, 2021
@AArnott AArnott added this to the v2.8 milestone Apr 5, 2021
@AArnott AArnott changed the title Fix for Issue #637 AddLocalRpcTarget<T> should honor base interfaces when T is an interface Apr 5, 2021
@AArnott
Copy link
Member

AArnott commented Apr 5, 2021

@rruizGit can you try again to sign the CLA?

@AArnott AArnott changed the base branch from main to v2.8 April 24, 2021 19:43
@AArnott AArnott merged commit b664ca8 into microsoft:v2.8 Apr 24, 2021
@AArnott AArnott modified the milestones: v2.8, v2.9 May 12, 2021
AArnott added a commit that referenced this pull request May 12, 2021
@AArnott
Revert "Merge pull request #652 from rruizGit/dev/rruiz/pr637"
8cd2c4a 
This reverts commit b664ca8, reversing
changes made to aa2f836.
AArnott added a commit that referenced this pull request May 12, 2021
@AArnott
Reapplies "Merge pull request #652 from rruizGit/dev/rruiz/pr637"
ccb5c03 
This reverts commit 8cd2c4a.
@AArnott
Copy link
Member

AArnott commented May 12, 2021

This didn't end up making the cut for v2.8. I've reverted the merge in v2.8 (8cd2c4a) and reapplied for v2.9 (in main, ccb5c03).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott approved these changes

Assignees

@AArnott AArnott

Labels
None yet
Projects
None yet
Milestone
v2.9
Development

Successfully merging this pull request may close these issues.

Usage mismatch between AddTarget<T> and Attach<T> when using interface inheritance.
2 participants
@rruizGit @AArnott