Honor ClientRequiresNamedArguments when UseSingleObjectParameterDeserialization is set #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ification from server when the client passes in a request with named parameters and the server is using SingleObjectParameterDeserialization
…ram deserialization so it can access client requires named params attribute
dibarbet
force-pushed
the
test_namedparams_singleobjectdeserialization
branch
from
7a5d2a9
to
b0c889f
Compare
Codecov Report
@@ Coverage Diff @@
## main #734 +/- ##
==========================================
+ Coverage 91.54% 91.56% +0.02%
==========================================
Files 60 60
Lines 5228 5230 +2
==========================================
+ Hits 4786 4789 +3
+ Misses 442 441 -1
Continue to review full report at Codecov.
|
AArnott
approved these changes
Nov 11, 2021
AArnott
changed the title
milopezc
approved these changes
Nov 11, 2021
|
thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while attempting to use the new attributes added in #733
Essentially when the client sends a request with a progress token using named parameters and the server is using
UseSingleObjectParameterDeserialization, vs-streamjsonrpc fails to pass along the value ofclientRequiresNamedArgumentsto theJsonProgressobject.This is exactly the configuration I hit as vscode uses named parameters and we make heavy use of
UseSingleObjectParameterDeserializationin our lsp server.The problem was that we essentially have a separate code path for handling RPC server methods that accept all args as a single argument (a special case built for LSP support), and we hadn't updated that code path to propagate the
JsonRpcMethodAttributein the special case.