-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honor user-provided Json IContractResolver while maintaining marshaling capabilities #783
Honor user-provided Json IContractResolver while maintaining marshaling capabilities #783
Conversation
Codecov Report
@@ Coverage Diff @@
## main #783 +/- ##
==========================================
+ Coverage 91.81% 91.86% +0.04%
==========================================
Files 61 61
Lines 5342 5360 +18
==========================================
+ Hits 4905 4924 +19
+ Misses 437 436 -1
Continue to review full report at Codecov.
|
Addressing failures similar to
when calling APIs under the following conditions:
IObserver<>
,IDisposable
or interfaces withRpcMarshalableAttribute
) objects as parameters or return valuesJsonMessageFormatter
'sContractResolver
.This issue has worsened since #777 due to more behavior being delegated to the
ContractResolver
This PR integrates the
ContractResolver
provided by the user withMarshalContractResolver
before the first serialization or deserialization.