Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to pass in an ActivitySource to be used for generating a new Activity #882

Merged
merged 4 commits into from
Jan 25, 2023

Conversation

CherechesC
Copy link
Contributor

If there is no listener attached to the activity source, the activity will not be created, so fallback to create the Activity using the constructor

Cristian Chereches added 3 commits January 24, 2023 23:46
…new Activity

If there is no listener attached to the activity source, the activity will not be created, so fallback to create the Activity using the constructor
Copy link
Member

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just one syntax improvement please.

src/StreamJsonRpc/ActivityTracingStrategy.cs Outdated Show resolved Hide resolved
Co-authored-by: Andrew Arnott <andrewarnott@gmail.com>
@AArnott AArnott added this to the v2.15 milestone Jan 25, 2023
@AArnott AArnott enabled auto-merge (squash) January 25, 2023 17:44
@AArnott AArnott merged commit f8847d2 into microsoft:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants