Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: Add stash and dispose methods for readonly contents #1719

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

JasonYeMSFT
Copy link
Contributor

  • The dispose method will allow an extension that uses the ReadOnlyContentProvider to offer a manual way to clear the contents stashed in its provider. This is not ideal but I think it's still better than not allowing people to dispose them at all.
  • The stash method adds the content to the internal content cache without opening the document. I want to use it in the Azure agent extension so I can present read-only content as a reference link in the chat window.

@JasonYeMSFT JasonYeMSFT requested a review from a team as a code owner April 11, 2024 18:24
@JasonYeMSFT JasonYeMSFT merged commit e68f1f4 into main Apr 11, 2024
4 checks passed
@JasonYeMSFT JasonYeMSFT deleted the dev/chuye/stash-dispose-readonly-content branch April 11, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants