auth: Refactor AzureDevOpsSubscriptionProvider so that it accepts values as arguments
#1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The most nitpick I've ever done: Can you prefix the PRs like "auth:" instead of "[auth]". We've been doing it that way and I want to stay consistent (as much as possible). The reasoning is when we generate changelogs on github it's much easier when all the commits are in the same format. |
hossam-nasr
changed the title
AzureDevOpsSubscriptionProvider so that it accepts values as argumentsAzureDevOpsSubscriptionProvider so that it accepts values as arguments
|
@alexweininger lol yes done 🫡 |
nturinski
reviewed
May 14, 2024
nturinski
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[auth package] modify the
AzureDevOpsSubscriptionProviderandAzureDevOpsSubscriptionProviderFactoryso that the three values required to identify the service connection: service connection ID, domain, and client ID, are passed as arguments to the constructor, rather than defaulting to being set as environment variables in the way we currently do. This allows for more versatility and flexibility in the way this provider can be used by other parties and users wanting to do their own E2E testing