Skip to content
This repository has been archived by the owner on Oct 2, 2021. It is now read-only.

Support "noDebug" parameter #89

Closed
roblourens opened this issue Sep 2, 2016 · 4 comments
Closed

Support "noDebug" parameter #89

roblourens opened this issue Sep 2, 2016 · 4 comments

Comments

@roblourens
Copy link
Member

From @jan-zajic on September 2, 2016 8:39

Please add support for nodebug : true parameter (Run mode - launch with ctrl+f5, see https://code.visualstudio.com/docs/editor/debugging#_run-mode). It was implemented in microsoft/vscode#2780. This should simple launch Chrome with specified url, without any debuger attaching, so we can use for examples dom inspector, debug css styles or use integrated debugger, which is sometimes better option.

Copied from original issue: Microsoft/vscode-chrome-debug#220

@roblourens roblourens changed the title "Run mode" - Support for launch without debugging Support "noDebug" parameter Sep 2, 2016
@auchenberg
Copy link
Contributor

Can we abstract this away in a some generic launch logic, where each debugger vscode-chrome-debug and vscode-edge-dubug simply provide the runtime executable and arguments?

Thinking this could be relevant for Electron, Edge, iOS, etc.

@roblourens
Copy link
Member Author

It might be easier for extensions to launch their own process then just check if (args.noDebug) before attaching to it. That's the only difference. Might be able to save them a call to spawn but it's not saving much.

@auchenberg
Copy link
Contributor

Makes sense, just wanted to make sure we didn't add Chrome specific logic in the core ;)

@roblourens
Copy link
Member Author

Moving back to vscode-chrome-debug

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants